Fixing issue with NUMERIC columns and mixing integer and floating point numbers - fixes #169

Author: mauricio

postgresql-async/src/main/scala/com/github/mauricio/async/db/postgresql/column/PostgreSQLColumnEncoderRegistry.scala

@@ -31,23 +31,23 @@ object PostgreSQLColumnEncoderRegistry {
 class PostgreSQLColumnEncoderRegistry extends ColumnEncoderRegistry {
 
   private val classesSequence_ : List[(Class[_], (ColumnEncoder, Int))] = List(
-    classOf[Int] -> (IntegerEncoderDecoder -> ColumnTypes.Integer),
-    classOf[java.lang.Integer] -> (IntegerEncoderDecoder -> ColumnTypes.Integer),
+    classOf[Int] -> (IntegerEncoderDecoder -> ColumnTypes.Numeric),
+    classOf[java.lang.Integer] -> (IntegerEncoderDecoder -> ColumnTypes.Numeric),
 
-    classOf[java.lang.Short] -> (ShortEncoderDecoder -> ColumnTypes.Smallint),
-    classOf[Short] -> (ShortEncoderDecoder -> ColumnTypes.Smallint),
+    classOf[java.lang.Short] -> (ShortEncoderDecoder -> ColumnTypes.Numeric),
+    classOf[Short] -> (ShortEncoderDecoder -> ColumnTypes.Numeric),
 
-    classOf[Long] -> (LongEncoderDecoder -> ColumnTypes.Bigserial),
-    classOf[java.lang.Long] -> (LongEncoderDecoder -> ColumnTypes.Bigserial),
+    classOf[Long] -> (LongEncoderDecoder -> ColumnTypes.Numeric),
+    classOf[java.lang.Long] -> (LongEncoderDecoder -> ColumnTypes.Numeric),
 
     classOf[String] -> (StringEncoderDecoder -> ColumnTypes.Varchar),
     classOf[java.lang.String] -> (StringEncoderDecoder -> ColumnTypes.Varchar),
 
-    classOf[Float] -> (FloatEncoderDecoder -> ColumnTypes.Real),
-    classOf[java.lang.Float] -> (FloatEncoderDecoder -> ColumnTypes.Real),
+    classOf[Float] -> (FloatEncoderDecoder -> ColumnTypes.Numeric),
+    classOf[java.lang.Float] -> (FloatEncoderDecoder -> ColumnTypes.Numeric),
 
-    classOf[Double] -> (DoubleEncoderDecoder -> ColumnTypes.Double),
-    classOf[java.lang.Double] -> (DoubleEncoderDecoder -> ColumnTypes.Double),
+    classOf[Double] -> (DoubleEncoderDecoder -> ColumnTypes.Numeric),
+    classOf[java.lang.Double] -> (DoubleEncoderDecoder -> ColumnTypes.Numeric),
 
     classOf[BigDecimal] -> (BigDecimalEncoderDecoder -> ColumnTypes.Numeric),
     classOf[java.math.BigDecimal] -> (BigDecimalEncoderDecoder -> ColumnTypes.Numeric),

postgresql-async/src/test/scala/com/github/mauricio/async/db/postgresql/NumericSpec.scala

@@ -22,7 +22,7 @@ class NumericSpec extends Specification with DatabaseTestHelper {
 
     }
 
-    "support first update of num column with integer (fails currently)" in {
+    "support first update of num column with integer" in {
 
       withHandler {
         handler =>

postgresql-async/src/test/scala/com/github/mauricio/async/db/postgresql/TimeAndDateSpec.scala

@@ -188,14 +188,31 @@ class TimeAndDateSpec extends Specification with DatabaseTestHelper {
 
       withTimeHandler {
         conn =>
-          val date1 = new DateTime(2190319)
+          val date = new DateTime(2190319)
 
-          await(conn.sendPreparedStatement("CREATE TEMP TABLE TEST(T TIMESTAMP)"))
-          await(conn.sendPreparedStatement("INSERT INTO TEST(T) VALUES(?)", Seq(date1)))
-          val result = await(conn.sendPreparedStatement("SELECT T FROM TEST"))
+          executePreparedStatement(conn, "CREATE TEMP TABLE TEST(T TIMESTAMP)")
+          executePreparedStatement(conn, "INSERT INTO TEST(T) VALUES(?)", Array(date))
+          val result = executePreparedStatement(conn, "SELECT T FROM TEST")
           val date2 = result.rows.get.head(0)
+          date2 === date.toDateTime(DateTimeZone.UTC).toLocalDateTime
+      }
+
+    }
+
+    "supports sending a local date and later a date time object for the same field" in {
+
+      withTimeHandler {
+        conn =>
+          val date = new LocalDate(2016, 3, 5)
+
+          executePreparedStatement(conn, "CREATE TEMP TABLE TEST(T TIMESTAMP)")
+          executePreparedStatement(conn, "INSERT INTO TEST(T) VALUES(?)", Array(date))
+          val result = executePreparedStatement(conn, "SELECT T FROM TEST WHERE T  = ?", Array(date))
+          result.rows.get.size === 1
 
-          date2 === date1.toDateTime(DateTimeZone.UTC).toLocalDateTime
+          val dateTime = new LocalDateTime(2016, 3, 5, 0, 0, 0, 0)
+          val dateTimeResult = executePreparedStatement(conn, "SELECT T FROM TEST WHERE T  = ?", Array(dateTime))
+          dateTimeResult.rows.get.size === 1
       }
 
     }