[Google Fonts] Fix loading fonts from assets and offline behavior #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move try/catch block outside loadFontIfNecessary
This reverts commit 2146168.
guidezpl
changed the title
clocksmith
approved these changes
Jan 29, 2020
Contributor
clocksmith
left a comment
clocksmith
left a comment
There was a problem hiding this comment.
So good. Thanks for addressing all of these issues!
Closed
guidezpl
added a commit
that referenced
this pull request
Feb 2, 2023
* Added outlineVariant and scrim color to ColorScheme * update pubspec and CHANGELOG --------- Co-authored-by: Pierre-Louis Guidez <[email protected]>
guidezpl
pushed a commit
that referenced
this pull request
Feb 2, 2023
… the component adapts to different navigation configurations. (#58) * Add NavigationType and overridable resolver function * clarify comments for resolving to specific navigation types * rami comments * typos * rami comments * Remove divider color
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes asset font loading and gracefully handles exception cases (i.e. offline) by printing errors to console. This PR also updates the bundling instructions and removes files which shouldn't be checked-in.
Related issues
Closes #40
Closes #31
Closes #28
#49
#54
#38