Print error instead of throwing

Move try/catch block outside loadFontIfNecessary

Author: guidezpl

lib/src/google_fonts_base.dart

@@ -94,7 +94,12 @@ TextStyle googleFontsTextStyle({
     fontUrl: fonts[matchedVariant],
   );
 
-  loadFontIfNecessary(descriptor);
+  try {
+    loadFontIfNecessary(descriptor);
+  } catch (e) {
+    final fontName = descriptor.familyWithVariant.toApiFilenamePrefix();
+    print('error: google_fonts was unable to load font $fontName\n$e');
+  }
 
   return textStyle.copyWith(
     fontFamily: familyWithVariant.toString(),
@@ -121,40 +126,34 @@ Future<void> loadFontIfNecessary(GoogleFontsDescriptor descriptor) async {
 
   Future<ByteData> byteData;
 
-  try {
-    // Check if this font can be loaded by the pre-bundled assets.
-    final assetManifestJson = await _loadAssetManifestJson();
-    final assetPath = getFamilyWithVariantManifestPath(
-      descriptor.familyWithVariant,
-      assetManifestJson,
-    );
-    if (assetPath != '') {
-      byteData = rootBundle.load(assetPath);
-    }
-    if (await byteData != null) {
-      return loadFontByteData(familyWithVariantString, byteData);
-    }
-
-    // Check if this font can be loaded from the device file system.
-    if (!kIsWeb) {
-      byteData = _loadFontFromDeviceFileSystem(familyWithVariantString);
-    }
-    if (await byteData != null) {
-      return loadFontByteData(familyWithVariantString, byteData);
-    }
+  // Check if this font can be loaded by the pre-bundled assets.
+  final assetManifestJson = await _loadAssetManifestJson();
+  final assetPath = getFamilyWithVariantManifestPath(
+    descriptor.familyWithVariant,
+    assetManifestJson,
+  );
+  if (assetPath != '') {
+    byteData = rootBundle.load(assetPath);
+  }
+  if (await byteData != null) {
+    return loadFontByteData(familyWithVariantString, byteData);
+  }
 
-    // Attempt to load this font via http.
-    byteData = _httpFetchFontAndSaveToDevice(
-      familyWithVariantString,
-      descriptor.fontUrl,
-    );
-    if (await byteData != null) {
-      return loadFontByteData(familyWithVariantString, byteData);
-    }
-  } catch (e) {
-    final fontName = descriptor.familyWithVariant.toApiFilenamePrefix();
-    throw Exception('google_fonts was unable to load font $fontName\n$e');
+  // Check if this font can be loaded from the device file system.
+  if (!kIsWeb) {
+    byteData = _loadFontFromDeviceFileSystem(familyWithVariantString);
+  }
+  if (await byteData != null) {
+    return loadFontByteData(familyWithVariantString, byteData);
   }
+
+  // Attempt to load this font via http.
+  byteData = _httpFetchFontAndSaveToDevice(
+    familyWithVariantString,
+    descriptor.fontUrl,
+  );
+  await byteData;
+  return loadFontByteData(familyWithVariantString, byteData);
 }
 
 /// Loads a font with [FontLoader], given its name and byte-representation.

test/load_font_if_necessary_test.dart

@@ -108,6 +108,33 @@ main() {
     );
   });
 
+  testWidgets('loadFontIfNecessary method throws if font cannot be loaded',
+      (tester) async {
+    // Mock a bad response.
+    when(httpClient.get(any)).thenAnswer((_) async {
+      return http.Response('fake response body - failure', 300);
+    });
+
+    final fooUrl = Uri.http('fonts.google.com', '/Foo');
+    final descriptorInAssets = GoogleFontsDescriptor(
+      familyWithVariant: GoogleFontsFamilyWithVariant(
+        family: 'Foo',
+        googleFontsVariant: GoogleFontsVariant(
+          fontWeight: FontWeight.w900,
+          fontStyle: FontStyle.italic,
+        ),
+      ),
+      fontUrl: fooUrl.toString(),
+    );
+
+    // Call loadFontIfNecessary and verify that it throws an exception.
+    expect(
+      loadFontIfNecessary(descriptorInAssets),
+      throwsA(predicate((e) => e.message.toString().startsWith(
+          'Failed to load font with url: http://fonts.google.com/Foo'))),
+    );
+  });
+
   testWidgets(
       'loadFontIfNecessary method does nothing if the font is in the '
       'Asset Manifest', (tester) async {
@@ -154,32 +181,4 @@ main() {
     await loadFontIfNecessary(descriptorNotInAssets);
     verify(httpClient.get(barUrl)).called(1);
   });
-
-  testWidgets('loadFontIfNecessary method throws if font cannot be loaded',
-      (tester) async {
-    // Mock a bad response.
-    when(httpClient.get(any)).thenAnswer((_) async {
-      return http.Response('fake response body - failure', 300);
-    });
-
-    final fooUrl = Uri.http('fonts.google.com', '/Foo');
-    final descriptorInAssets = GoogleFontsDescriptor(
-      familyWithVariant: GoogleFontsFamilyWithVariant(
-        family: 'Foo',
-        googleFontsVariant: GoogleFontsVariant(
-          fontWeight: FontWeight.w900,
-          fontStyle: FontStyle.italic,
-        ),
-      ),
-      fontUrl: fooUrl.toString(),
-    );
-
-    // Call loadFontIfNecessary and verify that it throws an exception.
-    expect(
-      loadFontIfNecessary(descriptorInAssets),
-      throwsA(predicate((e) => e.message
-          .toString()
-          .startsWith('google_fonts was unable to load font Foo'))),
-    );
-  });
 }