Fixed issues from Codacy

Author: rijnb

test/run_compare.sh

@@ -10,7 +10,7 @@ OPTS1="--grid 1000000 8"
 OPTS2="--random 1000000 8 1234"
 OPTS3="--random 1000000 8 11223344"
 
-TEST=`which $OLD`
+TEST=$(which $OLD)
 if [ "$TEST" = "" ]
 then
     echo "No $OLD found on this machine - skipping script..."
@@ -30,7 +30,7 @@ cd ../utility
 gcc $OPTS -O3 mapcode.cpp -lm -o mapcode ../mapcodelib/mapcoder.o
 cd ../test
 
-TEST=`which $NEW`
+TEST=$(which $NEW)
 if [ "$TEST" = "" ]
 then
     echo "No $NEW found on this machine - skipping script..."

test/run_gcov.sh

@@ -2,7 +2,7 @@
 OPTS="-Wall -Werror -Wextra -Wno-pointer-to-int-cast -fprofile-arcs -ftest-coverage"
 LIB="../mapcodelib/mapcoder.o"
 
-TEST=`which gcov`
+TEST=$(which gcov)
 if [ "$TEST" = "" ]
 then
     echo "No gcov found on this machine - skipping script..."

test/run_gprof.sh

@@ -2,7 +2,7 @@
 OPTS="-Wall -Werror -Wextra -Wno-pointer-to-int-cast"
 LIB="../mapcodelib/mapcoder.o"
 
-TEST=`which gprof`
+TEST=$(which gprof)
 if [ "$TEST" = "" ]
 then
     echo "No gprof found on this machine - skipping script..."

test/run_sanitizer.sh

@@ -4,7 +4,7 @@ LIB="../mapcodelib/mapcoder.o"
 
 export ASAN_OPTIONS=debug=true:strict_string_checks=1:detect_stack_use_after_return=true:detect_invalid_pointer_pairs=99999:detect_container_overflow=true:detect_odr_violation=2:check_initialization_order=true:strict_init_order=true
 
-TEST=`which clang`
+TEST=$(which clang)
 if [ "$TEST" = "" ]
 then
     echo "No clang found on this machine - skipping script..."

test/run_valgrind.sh

@@ -2,7 +2,7 @@
 OPTS="-Wall -Werror -Wextra -Wno-pointer-to-int-cast"
 LIB="../mapcodelib/mapcoder.o"
 
-TEST=`which valgrind`
+TEST=$(which valgrind)
 if [ "$TEST" = "" ]
 then
     echo "No valgrind found on this machine - skipping script..."

utility/mapcode.cpp

@@ -447,7 +447,7 @@ int main(const int argc, const char **argv) {
                (strcmp(cmd, "--encode") == 0) || (strcmp(cmd, "--encode0") == 0) ||
                (strcmp(cmd, "--encode1") == 0) || (strcmp(cmd, "--encode2") == 0) ||
                (strcmp(cmd, "--encode3") == 0) || (strcmp(cmd, "--encode4") == 0) ||
-               (strcmp(cmd, "--encode5") == 0) || (strcmp(cmd, "--encode5") == 0) ||
+               (strcmp(cmd, "--encode5") == 0) || (strcmp(cmd, "--encode6") == 0) ||
                (strcmp(cmd, "--encode7") == 0) || (strcmp(cmd, "--encode8") == 0)) {
 
         // ------------------------------------------------------------------