#41 feat: select all text when tapping latitude and longitude

Signed-off-by: sds100 <[email protected]>

Author: sds100

app/src/androidTest/java/com/mapcode/map/MapScreenTest.kt

@@ -1,9 +1,11 @@
 package com.mapcode.map
 
 import android.Manifest
+import androidx.compose.ui.semantics.SemanticsProperties
 import androidx.compose.ui.semantics.SemanticsPropertyKey
 import androidx.compose.ui.test.*
 import androidx.compose.ui.test.junit4.createComposeRule
+import androidx.compose.ui.text.TextRange
 import androidx.test.rule.GrantPermissionRule
 import assertk.assertThat
 import assertk.assertions.isEqualTo
@@ -50,7 +52,7 @@ class MapScreenTest {
 
         composeTestRule.onNodeWithText("Mapcode").performClick()
 
-        assertThat(useCase.clipboard).isEqualTo("AAA AB.XY")
+        assertThat(useCase.clipboard).isEqualTo("AB.XY")
     }
 
     @Test
@@ -64,9 +66,9 @@ class MapScreenTest {
         setMapScreenAsContent()
         viewModel.onCameraMoved(0.0, 0.0, 0f)
 
-        composeTestRule.onNodeWithText("AAA AB.XY").performClick()
+        composeTestRule.onNodeWithText("AB.XY").performClick()
 
-        assertThat(useCase.clipboard).isEqualTo("AAA AB.XY")
+        assertThat(useCase.clipboard).isEqualTo("AB.XY")
     }
 
     @Test
@@ -81,7 +83,7 @@ class MapScreenTest {
 
         setMapScreenAsContent()
 
-        composeTestRule.onNodeWithText("AAA AB.XY").performClick()
+        composeTestRule.onNodeWithText("AB.XY").performClick()
 
         composeTestRule.waitForIdle()
 
@@ -388,7 +390,7 @@ class MapScreenTest {
 
         composeTestRule.onNodeWithContentDescription("Share mapcode").performClick()
 
-        assertThat(useCase.sharedText).isEqualTo("AAA AB.XY")
+        assertThat(useCase.sharedText).isEqualTo("AB.XY")
     }
 
     @Test
@@ -569,6 +571,34 @@ class MapScreenTest {
         composeTestRule.onNodeWithText("Enter address or mapcode").assertIsNotFocused()
     }
 
+    @Test
+    fun select_latitude_text_when_focussing() {
+        useCase.knownLocations.add(
+            FakeLocation(0.0, 0.0, emptyList(), mapcodes = emptyList())
+        )
+        setMapScreenAsContent()
+        viewModel.onCameraMoved(0.0, 0.0, 1f)
+
+        composeTestRule.onNodeWithText("Latitude (Y)").apply {
+            performClick()
+            assert(SemanticsMatcher.expectValue(SemanticsProperties.TextSelectionRange, TextRange(0, 9)))
+        }
+    }
+
+    @Test
+    fun select_longitude_text_when_focussing() {
+        useCase.knownLocations.add(
+            FakeLocation(0.0, 0.0, emptyList(), mapcodes = emptyList())
+        )
+        setMapScreenAsContent()
+        viewModel.onCameraMoved(0.0, 0.0, 1f)
+
+        composeTestRule.onNodeWithText("Longitude (X)").apply {
+            performClick()
+            assert(SemanticsMatcher.expectValue(SemanticsProperties.TextSelectionRange, TextRange(0, 9)))
+        }
+    }
+
     private fun setMapScreenAsContent() {
         composeTestRule.setContent {
             MapScreen(viewModel = viewModel, renderGoogleMaps = false)

app/src/main/java/com/mapcode/map/InfoScreenPart.kt

@@ -2,6 +2,7 @@
 
 package com.mapcode.map
 
+import android.annotation.SuppressLint
 import android.os.Build
 import androidx.annotation.DrawableRes
 import androidx.compose.foundation.ExperimentalFoundationApi
@@ -16,14 +17,17 @@ import androidx.compose.runtime.*
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.focus.FocusRequester
 import androidx.compose.ui.focus.focusRequester
+import androidx.compose.ui.focus.onFocusChanged
 import androidx.compose.ui.platform.LocalFocusManager
 import androidx.compose.ui.res.painterResource
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.text.SpanStyle
+import androidx.compose.ui.text.TextRange
 import androidx.compose.ui.text.buildAnnotatedString
 import androidx.compose.ui.text.font.FontWeight
 import androidx.compose.ui.text.input.ImeAction
 import androidx.compose.ui.text.input.KeyboardType
+import androidx.compose.ui.text.input.TextFieldValue
 import androidx.compose.ui.tooling.preview.Preview
 import androidx.compose.ui.unit.dp
 import com.mapcode.R
@@ -336,6 +340,7 @@ private fun LongitudeTextBox(
     )
 }
 
+@SuppressLint("UnrememberedMutableState")
 @Composable
 private fun LatLngTextField(
     modifier: Modifier = Modifier,
@@ -350,15 +355,35 @@ private fun LatLngTextField(
     Column(modifier) {
         val focusManager = LocalFocusManager.current
         val focusRequester = remember { FocusRequester() }
+        var textSelection: TextRange by remember { mutableStateOf(TextRange.Zero) }
+
+        val textValue: TextFieldValue by derivedStateOf { TextFieldValue(text, textSelection) }
+
+        var selectAllText: Boolean by remember { mutableStateOf(false) }
+
+        if (selectAllText) {
+            SideEffect {
+                textSelection = TextRange(0, text.length)
+                selectAllText = false
+            }
+        }
 
         OutlinedTextField(
             modifier = Modifier
                 .focusRequester(focusRequester)
+                .onFocusChanged { state ->
+                    if (state.isFocused) {
+                        selectAllText = true
+                    }
+                }
                 .fillMaxWidth(),
-            value = text,
+            value = textValue,
             singleLine = true,
             label = { Text(label, maxLines = 1) },
-            onValueChange = onChange,
+            onValueChange = { value ->
+                textSelection = value.selection
+                onChange(value.text)
+            },
             keyboardOptions = KeyboardOptions(
                 imeAction = ImeAction.Go,
                 keyboardType = KeyboardType.Decimal