Update sdk 3.0 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to fix the compilation of all the tests.
mathieugh
reviewed
Apr 6, 2021
Comment on lines
+17
to
+18
| "module": "./dist/lib/esm/index.js", | ||
| "main": "./dist/lib/cjs/index.js", |
Collaborator
There was a problem hiding this comment.
Pourquoi ici c'est dans differentes libs ?
Author
There was a problem hiding this comment.
J'ai copié notre package.json qu'on a dans pristine.
mathieugh
reviewed
Apr 6, 2021
| import {Marshaller} from "./Marshaller"; | ||
| import {BinarySet} from "./BinarySet"; | ||
| import {NumberValue} from "./NumberValue"; | ||
| import {NumberValueSet} from "./NumberValueSet"; |
Collaborator
There was a problem hiding this comment.
Tous les tests sont commentés ici c'est voulu ?
Author
There was a problem hiding this comment.
Oh merde je pensais que ce bogue était réglé merci.
mathieugh
reviewed
Apr 6, 2021
|
|
||
| for (const asyncInput of [true, false]) { | ||
| const asyncInput = false; | ||
| //for (const asyncInput of [false, true]) { |
Author
There was a problem hiding this comment.
Je pourrais le remettre mais en gros j'ai splitté les tests en deux et je set la variable mais je vais le remettre comme c'était.
mathieugh
reviewed
Apr 6, 2021
| 'table', | ||
| {DeleteRequest: {Key: {foo: {B: '🐎👱❤'}}}} | ||
| 'table', | ||
| {DeleteRequest: {Key: {foo: {B: new TextEncoder().encode('🐎👱❤')}}}} |
Collaborator
There was a problem hiding this comment.
Wow on s'amuse avec des emojis ici
mathieugh
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.