Resolves #2705: add explicit set of path component to generated uri #3339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @davidalger! we're processing this now. Internal ticket: MAGETWO-49668 |
sshrewz
added
the
Issue: Ready for Work
magento-team
pushed a commit
that referenced
this pull request
Mar 12, 2016
This was referenced Mar 25, 2016
Member
Author
|
@mazhalai Do you know if this is planned for inclusion in the next patch release for 2.0? |
Member
Author
|
FTR - This fix was shipped in the 2.0.6 patch release it seems. |
davidalger
pushed a commit
to davidalger/capistrano-magento2
that referenced
this pull request
May 25, 2016
…ploy procedure The underlying issue requiring this be used to purge varnish on cache flush (see magento/magento2#3339 for details) was shipped in the Magento 2.0.6 release. However, while cache:clean does send PURGE requests to varnish for the various tags which Magento uses, a cache:flush does not send anything to varnish, requiring a manual PURGE. So this will be left in here to facilitate sending a PURGE to varnish for the entire cache pool.
magento-engcom-team
pushed a commit
that referenced
this pull request
Nov 9, 2018
Fixed issues: - MAGETWO-95411: [Backport 2.2.x] Add the ability to install Magento without creating an administrator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2705 and #3315. Zend URI classes only add a / automatically if there is either a query or fragment present. There is no query or fragment on the URI for varnish purge requests, so we must explicitly set the path component for it to be correctly included in the request URI. See #2705 (comment) for further details.