From 1e209aad6f9d3b9cce90421728e4641b6f567429 Mon Sep 17 00:00:00 2001 From: Namrata Vora Date: Tue, 15 Oct 2019 14:00:26 +0530 Subject: [PATCH 1/2] Removed unnecessary duplicated words and XML comments. --- .../Test/Mftf/ActionGroup/AdminProductGridActionGroup.xml | 2 +- .../Checkout/Test/Mftf/ActionGroup/CheckoutActionGroup.xml | 2 +- .../Mftf/ActionGroup/AdminConfigCreateNewAccountActionGroup.xml | 2 +- .../Tinymce3/view/base/web/tiny_mce/classes/html/Node.js | 2 +- .../Magento/Framework/App/Request/InvalidRequestException.php | 2 +- .../Framework/GraphQl/Query/IntrospectionConfiguration.php | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductGridActionGroup.xml b/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductGridActionGroup.xml index aef79e651b584..320a322fc5f8e 100644 --- a/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductGridActionGroup.xml +++ b/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductGridActionGroup.xml @@ -389,7 +389,7 @@ - + Goes to the Admin Products grid. Filters the Product grid by the provided Product SKU. diff --git a/app/code/Magento/Checkout/Test/Mftf/ActionGroup/CheckoutActionGroup.xml b/app/code/Magento/Checkout/Test/Mftf/ActionGroup/CheckoutActionGroup.xml index 66f8ed541ffd9..e0519a126aa48 100644 --- a/app/code/Magento/Checkout/Test/Mftf/ActionGroup/CheckoutActionGroup.xml +++ b/app/code/Magento/Checkout/Test/Mftf/ActionGroup/CheckoutActionGroup.xml @@ -222,7 +222,7 @@ - Validates the the provided Product appears in the Storefront Checkout 'Order Summary' section. + Validates the provided Product appears in the Storefront Checkout 'Order Summary' section. diff --git a/app/code/Magento/Config/Test/Mftf/ActionGroup/AdminConfigCreateNewAccountActionGroup.xml b/app/code/Magento/Config/Test/Mftf/ActionGroup/AdminConfigCreateNewAccountActionGroup.xml index 10d22b61ecae0..2a3a14293a059 100644 --- a/app/code/Magento/Config/Test/Mftf/ActionGroup/AdminConfigCreateNewAccountActionGroup.xml +++ b/app/code/Magento/Config/Test/Mftf/ActionGroup/AdminConfigCreateNewAccountActionGroup.xml @@ -10,7 +10,7 @@ xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd"> - Goes to the 'Configuration' page for 'Customer Configuration'. Sets the 'Group For Valid VAT ID Intra Union' option. Clicks on the Save button. Validates the the Save message is present. + Goes to the 'Configuration' page for 'Customer Configuration'. Sets the 'Group For Valid VAT ID Intra Union' option. Clicks on the Save button. Validates the Save message is present. diff --git a/app/code/Magento/Tinymce3/view/base/web/tiny_mce/classes/html/Node.js b/app/code/Magento/Tinymce3/view/base/web/tiny_mce/classes/html/Node.js index 41cc0d9813bfa..58074216458ee 100644 --- a/app/code/Magento/Tinymce3/view/base/web/tiny_mce/classes/html/Node.js +++ b/app/code/Magento/Tinymce3/view/base/web/tiny_mce/classes/html/Node.js @@ -197,7 +197,7 @@ }, /** - * Wraps the node in in another node. + * Wraps the node in another node. * * @example * node.wrap(wrapperNode); diff --git a/lib/internal/Magento/Framework/App/Request/InvalidRequestException.php b/lib/internal/Magento/Framework/App/Request/InvalidRequestException.php index f15ce494e9bb4..443b2d9620df1 100644 --- a/lib/internal/Magento/Framework/App/Request/InvalidRequestException.php +++ b/lib/internal/Magento/Framework/App/Request/InvalidRequestException.php @@ -32,7 +32,7 @@ class InvalidRequestException extends RuntimeException /** * @param ResponseInterface|ResultInterface|NotFoundException $replaceResult * Use this result instead of calling an action instance, - * if NotFoundException is given the the default 404 mechanism will be triggered. + * if NotFoundException is given the default 404 mechanism will be triggered. * @param Phrase[]|null $messages Messages to show to client * as error messages. */ diff --git a/lib/internal/Magento/Framework/GraphQl/Query/IntrospectionConfiguration.php b/lib/internal/Magento/Framework/GraphQl/Query/IntrospectionConfiguration.php index 2fdb3df5f6d71..2c498b0b7fd03 100644 --- a/lib/internal/Magento/Framework/GraphQl/Query/IntrospectionConfiguration.php +++ b/lib/internal/Magento/Framework/GraphQl/Query/IntrospectionConfiguration.php @@ -31,7 +31,7 @@ public function __construct( } /** - * Check the the environment config to determine if introspection should be disabled. + * Check the environment config to determine if introspection should be disabled. * * @return bool */ From ae322be3435187ae09bc1532ea38ca49952e38e8 Mon Sep 17 00:00:00 2001 From: Nazarn96 Date: Wed, 16 Oct 2019 12:23:45 +0300 Subject: [PATCH 2/2] static-test fix --- .../Magento/Framework/App/Request/InvalidRequestException.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/internal/Magento/Framework/App/Request/InvalidRequestException.php b/lib/internal/Magento/Framework/App/Request/InvalidRequestException.php index 443b2d9620df1..e15a5151942f0 100644 --- a/lib/internal/Magento/Framework/App/Request/InvalidRequestException.php +++ b/lib/internal/Magento/Framework/App/Request/InvalidRequestException.php @@ -45,6 +45,8 @@ public function __construct($replaceResult, ?array $messages = null) } /** + * Return replaced result + * * @return ResponseInterface|ResultInterface|NotFoundException */ public function getReplaceResult() @@ -53,6 +55,8 @@ public function getReplaceResult() } /** + * Return messages + * * @return Phrase[]|null */ public function getMessages(): ?array