Skip to content

Resolve Mass Delete Subscribers doesn't have "confirm" message issue24248 #24249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2019
Merged

Resolve Mass Delete Subscribers doesn't have "confirm" message issue24248 #24249

merged 1 commit into from
Aug 28, 2019

Conversation

edenduong
Copy link
Contributor

Description (*)

  1. Resolve Mass Delete Subscribers doesn't have "confirm" message #24248: Mass Delete Subscribers doesn't have "confirm" message

Fixed Issues (if relevant)

  1. Mass Delete Subscribers doesn't have "confirm" message #24248: Mass Delete Subscribers doesn't have "confirm" message

Manual testing scenarios (*)

  1. Go to backend
  2. Marketing->Newsletter Subscribers
  3. Choose some subscribers
  4. Choose mass action delete
  5. Submit

Expected result

image

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 23, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@kalpmehta kalpmehta self-assigned this Aug 23, 2019
ihor-sviziev
ihor-sviziev reviewed Aug 23, 2019
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add there amount of selected subscribers? Would be great to have it

@edenduong
Copy link
Contributor Author

Is it possible to add there amount of selected subscribers? Would be great to have it

I think it is impossible because in newsletter_subscriber_block.xml, there is no way to get the number of selected.

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests build

@ihor-sviziev ihor-sviziev self-assigned this Aug 23, 2019
@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Aug 23, 2019
@ihor-sviziev
Copy link
Contributor

I think it is impossible because in newsletter_subscriber_block.xml, there is no way to get the number of selected.

Ok, let's leave as is for now. Later it could be improved.

There also were functional tests failures, but they looks not related at all.

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-5682 has been created to process this Pull Request

@ghost ghost assigned VladimirZaets Aug 23, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-5682 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @kalpmehta, thank you for the review.
ENGCOM-5682 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Aug 27, 2019
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Aug 27, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Aug 28, 2019
Closed
magento-engcom-team pushed a commit that referenced this pull request Aug 28, 2019
@sidolov
ENGCOM-5682: Resolve Mass Delete Subscribers doesn't have "confirm" m…
f5bcf38 
…essage issue24248 #24249
@magento-engcom-team magento-engcom-team merged commit 01edbdc into magento:2.3-develop Aug 28, 2019
@m2-assistant
Copy link

m2-assistant bot commented Aug 28, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@VladimirZaets VladimirZaets VladimirZaets approved these changes

@kalpmehta kalpmehta kalpmehta approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@VladimirZaets VladimirZaets

@kalpmehta kalpmehta

@engcom-Delta engcom-Delta

@engcom-Foxtrot engcom-Foxtrot

Labels
Area: Frontend Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Award: bug fix Component: Newsletter Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.4
Development

Successfully merging this pull request may close these issues.

Mass Delete Subscribers doesn't have "confirm" message
8 participants
@edenduong @ihor-sviziev @magento-engcom-team @engcom-Delta @VladimirZaets @kalpmehta @sidolov @engcom-Foxtrot