From d7606f4cb8ca4769d49123aea69bb61b527a1c1b Mon Sep 17 00:00:00 2001 From: Eden Date: Wed, 14 Aug 2019 22:51:03 +0700 Subject: [PATCH 1/2] Resolve Console error when clicking checkbox at "Newsletter Problems Report" (issue 24102) --- .../view/adminhtml/templates/problem/list.phtml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/app/code/Magento/Newsletter/view/adminhtml/templates/problem/list.phtml b/app/code/Magento/Newsletter/view/adminhtml/templates/problem/list.phtml index a3d88de9d35b2..29382930df3e6 100644 --- a/app/code/Magento/Newsletter/view/adminhtml/templates/problem/list.phtml +++ b/app/code/Magento/Newsletter/view/adminhtml/templates/problem/list.phtml @@ -18,9 +18,11 @@ require(["prototype", "mage/adminhtml/events"], function(){ problemController = { checkCheckboxes:function (controlCheckbox) { var elements = $('problemGrid').getElementsByClassName('problemCheckbox'); - elements.each(function (obj) { - obj.checked = controlCheckbox.checked; - }); + if (elements && elements.length) { + elements.each(function (obj) { + obj.checked = controlCheckbox.checked; + }); + } }, rowClick:function (e) { if (!Event.element(e).hasClassName('problemCheckbox')) { From 86d5c2254cf3cd50051f83c30fd873c0657e6977 Mon Sep 17 00:00:00 2001 From: Eden Date: Fri, 16 Aug 2019 15:20:57 +0700 Subject: [PATCH 2/2] Resolve Console error when clicking checkbox at "Newsletter Problems Report" (issue 24102) --- .../Newsletter/view/adminhtml/templates/problem/list.phtml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/Newsletter/view/adminhtml/templates/problem/list.phtml b/app/code/Magento/Newsletter/view/adminhtml/templates/problem/list.phtml index 29382930df3e6..b697be4cf753a 100644 --- a/app/code/Magento/Newsletter/view/adminhtml/templates/problem/list.phtml +++ b/app/code/Magento/Newsletter/view/adminhtml/templates/problem/list.phtml @@ -17,7 +17,7 @@ require(["prototype", "mage/adminhtml/events"], function(){ problemController = { checkCheckboxes:function (controlCheckbox) { - var elements = $('problemGrid').getElementsByClassName('problemCheckbox'); + var elements = $$('input.problemCheckbox'); if (elements && elements.length) { elements.each(function (obj) { obj.checked = controlCheckbox.checked;