Prevent XSS on checkout #18487
Merged
Prevent XSS on checkout #18487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
magento-engcom-team
added
partners-contribution
Contributor
|
Hi @samgranger , please, sign CLA, otherwise, we can't process your pull request |
Contributor
Author
|
CLA signed! |
sidolov
approved these changes
Oct 10, 2018
Contributor
|
Hi @sidolov, thank you for the review. |
Contributor
|
@samgranger thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
Contributor
Author
|
I'm not sure if I already have the permissions you mentioned, I don't see any pending invitations when visiting the given link. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Oct 12, 2018
Contributor
|
Hi @samgranger. Thank you for your contribution. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The State/Province field (when selecting a country like The Netherlands) gives the user an input field (in checkout/account address). When filling <script>alert('hello world')</script>, the user will experience self xss in the next step of the checkout.
Fixed Issues (if relevant)
Bugcrowd reference cd8d0c3b57686f09cde51c4afaa2f0e70e51f9093121fb7140e3b7f26a89b7fd (which got marked as "won't fix")
Manual testing scenarios
See description/ (bugcrowd for video)
Contribution checklist