Skip to content

[2.3] Admin Grid column ordering/positioning not working when single store mode set On #18405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2018
Merged

[2.3] Admin Grid column ordering/positioning not working when single store mode set On #18405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion app/code/Magento/Ui/view/base/web/js/core/renderer/layout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ define([
*/
build: function (parent, node, name) {
var defaults = parent && parent.childDefaults || {},
children = node.children,
children = this.filterDisabledChildren(node.children),
type = getNodeType(parent, node),
dataScope = getDataScope(parent, node),
component,
Expand Down Expand Up @@ -294,6 +294,35 @@ define([
return node;
},

/**
* Filter out all disabled components.
*
* @param {Object} children
* @returns {*}
*/
filterDisabledChildren: function (children) {
var cIds;

//cleanup children config.componentDisabled = true
if (children && typeof children === 'object') {
cIds = Object.keys(children);

if (cIds) {
_.each(cIds, function (cId) {
if (typeof children[cId] === 'object' &&
children[cId].hasOwnProperty('config') &&
typeof children[cId].config === 'object' &&
children[cId].config.hasOwnProperty('componentDisabled') &&
children[cId].config.componentDisabled === true) {
delete children[cId];
}
});
}
}

return children;
},

/**
* Init component.
*
Expand Down