Skip to content

Conversation

@gwharton
Copy link
Contributor

@gwharton gwharton commented Oct 5, 2018

added component status based filtering

Description

New functionality filters out all disabled UI components (based on internal logic some components are not applicable when the store has single store mode enabled) as it affects children length comparison and different useful UX behaviours.

Fixed Issues

  1. M2.2.0 Admin Grid column ordering/positioning not working when single store mode set On #12070 M2.2.0 Admin Grid column ordering/positioning not working when single store mode set On

Manual testing scenarios

  1. Install Magento
  2. Ensure single store mode on
  3. View sales order grid
  4. Launch Browser development tools and monitor network traffic.
  5. Move a column. If there is an AJAX call after each column move, then the fix has worked. Without the fix, there will be no AJAX calls for each column move.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@gwharton
Copy link
Contributor Author

gwharton commented Oct 5, 2018

2.2-develop PR is here #17512

@gwharton
Copy link
Contributor Author

gwharton commented Oct 5, 2018

Note, if during testing you see that column positioning is not working properly, you may also be running into issue #17691 which remains unfixed. This PR addresses only the issue of the missing AJAX calls.

@magento-engcom-team
Copy link
Contributor

Hi @josefbehr, thank you for the review.
ENGCOM-3106 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit ed1f6a5 into magento:2.3-develop Oct 12, 2018
magento-engcom-team pushed a commit that referenced this pull request Oct 12, 2018
@magento-engcom-team
Copy link
Contributor

Hi @gwharton. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants