From 5937495fca6903d999896657bc36f698225cb454 Mon Sep 17 00:00:00 2001 From: Neeta Kangiya Date: Thu, 4 Oct 2018 12:28:16 +0530 Subject: [PATCH 1/4] resolve typo in dispatchevent --- .../Model/Indexer/Fulltext/Action/DataProvider.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/CatalogSearch/Model/Indexer/Fulltext/Action/DataProvider.php b/app/code/Magento/CatalogSearch/Model/Indexer/Fulltext/Action/DataProvider.php index 381fb573b21a1..80034eb9f8308 100644 --- a/app/code/Magento/CatalogSearch/Model/Indexer/Fulltext/Action/DataProvider.php +++ b/app/code/Magento/CatalogSearch/Model/Indexer/Fulltext/Action/DataProvider.php @@ -317,7 +317,7 @@ public function getSearchableAttributes($backendType = null) $attributes = $productAttributes->getItems(); $this->eventManager->dispatch( - 'catelogsearch_searchable_attributes_load_after', + 'catalogsearch_searchable_attributes_load_after', ['engine' => $this->engine, 'attributes' => $attributes] ); From e8781055d6a6ad183a09c45b8b3bf788d5615cc6 Mon Sep 17 00:00:00 2001 From: Neeta Kangiya Date: Fri, 19 Oct 2018 11:44:40 +0530 Subject: [PATCH 2/4] add deprectaed in event arguments --- .../Model/Indexer/Fulltext/Action/DataProvider.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/code/Magento/CatalogSearch/Model/Indexer/Fulltext/Action/DataProvider.php b/app/code/Magento/CatalogSearch/Model/Indexer/Fulltext/Action/DataProvider.php index 80034eb9f8308..ff9cc7e919170 100644 --- a/app/code/Magento/CatalogSearch/Model/Indexer/Fulltext/Action/DataProvider.php +++ b/app/code/Magento/CatalogSearch/Model/Indexer/Fulltext/Action/DataProvider.php @@ -316,6 +316,10 @@ public function getSearchableAttributes($backendType = null) /** @var \Magento\Eav\Model\Entity\Attribute[] $attributes */ $attributes = $productAttributes->getItems(); + /** + * Event argument `catelogsearch_searchable_attributes_load_after` is @deprecated 100.2.5. Use + * `catalogsearch_searchable_attributes_load_after` instead. + */ $this->eventManager->dispatch( 'catalogsearch_searchable_attributes_load_after', ['engine' => $this->engine, 'attributes' => $attributes] From 6178035ece28d2a6a40fefcb09859515d78157a2 Mon Sep 17 00:00:00 2001 From: Neeta Kangiya Date: Mon, 29 Oct 2018 16:11:02 +0530 Subject: [PATCH 3/4] add old event --- .../Model/Indexer/Fulltext/Action/DataProvider.php | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/code/Magento/CatalogSearch/Model/Indexer/Fulltext/Action/DataProvider.php b/app/code/Magento/CatalogSearch/Model/Indexer/Fulltext/Action/DataProvider.php index ff9cc7e919170..37ef0a7689f9d 100644 --- a/app/code/Magento/CatalogSearch/Model/Indexer/Fulltext/Action/DataProvider.php +++ b/app/code/Magento/CatalogSearch/Model/Indexer/Fulltext/Action/DataProvider.php @@ -317,9 +317,14 @@ public function getSearchableAttributes($backendType = null) $attributes = $productAttributes->getItems(); /** - * Event argument `catelogsearch_searchable_attributes_load_after` is @deprecated 100.2.5. Use + * Event argument `catelogsearch_searchable_attributes_load_after` is @deprecated. Use * `catalogsearch_searchable_attributes_load_after` instead. */ + $this->eventManager->dispatch( + 'catelogsearch_searchable_attributes_load_after', + ['engine' => $this->engine, 'attributes' => $attributes] + ); + $this->eventManager->dispatch( 'catalogsearch_searchable_attributes_load_after', ['engine' => $this->engine, 'attributes' => $attributes] From 2647a89266b6fca8a9fb1b885091da67cfb2c693 Mon Sep 17 00:00:00 2001 From: Neeta Kangiya Date: Mon, 29 Oct 2018 16:29:54 +0530 Subject: [PATCH 4/4] add proper @deprecated and @see --- .../Model/Indexer/Fulltext/Action/DataProvider.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/code/Magento/CatalogSearch/Model/Indexer/Fulltext/Action/DataProvider.php b/app/code/Magento/CatalogSearch/Model/Indexer/Fulltext/Action/DataProvider.php index 37ef0a7689f9d..286b6427c8132 100644 --- a/app/code/Magento/CatalogSearch/Model/Indexer/Fulltext/Action/DataProvider.php +++ b/app/code/Magento/CatalogSearch/Model/Indexer/Fulltext/Action/DataProvider.php @@ -317,8 +317,8 @@ public function getSearchableAttributes($backendType = null) $attributes = $productAttributes->getItems(); /** - * Event argument `catelogsearch_searchable_attributes_load_after` is @deprecated. Use - * `catalogsearch_searchable_attributes_load_after` instead. + * @deprecated Event argument catelogsearch_searchable_attributes_load_after. + * @see catalogsearch_searchable_attributes_load_after instead. */ $this->eventManager->dispatch( 'catelogsearch_searchable_attributes_load_after',