Skip to content

[Backport] Fix throwing error by checkout error processor model #18369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2018
Merged

[Backport] Fix throwing error by checkout error processor model #18369

merged 1 commit into from
Oct 4, 2018

Conversation

@ihor-sviziev
Copy link
Contributor

@ihor-sviziev ihor-sviziev commented Oct 4, 2018

Original Pull Request

#18331

Description

See #18330 for steps to reproduce and additional details

Fixed Issues (if relevant)

  1. Checkout - Infinite loading indicator when server returned error #18330: Checkout - Infinite loading indicator when server returned error

Manual testing scenarios

See #18330

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Oct 4, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 4, 2018

Hi @sidolov, thank you for the review.
ENGCOM-3088 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team mentioned this pull request Oct 4, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 74bed69 into magento:2.2-develop Oct 4, 2018
magento-engcom-team pushed a commit that referenced this pull request Oct 4, 2018
ENGCOM-3088: [Backport] Fix throwing error by checkout error processo…
1f2d515 
…r model #18369
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 4, 2018

Hi @ihor-sviziev. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@ihor-sviziev ihor-sviziev deleted the 2.2-develop-PR-port-18331 branch October 9, 2018 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sidolov sidolov sidolov approved these changes

Assignees

@sidolov sidolov

Labels

Area: Frontend Component: Checkout Progress: accept Release Line: 2.2

Projects

None yet

Milestone

Release: 2.2.8

Development

Successfully merging this pull request may close these issues.

3 participants

@ihor-sviziev @magento-engcom-team @sidolov