Fix issue 17152 - prevent email being marked as not sent if email cop…

[sambolek]

Description

Prevent email being marked as not sent if email copy fails due to exception.

Fixed Issues (if relevant)

1. Failure of "Send Order Email Copy" spams customers, every minute, forever. #17152 Failure of "Send Order Email Copy" spams customers, every minute, forever.

Manual testing scenarios

Provided inside reported issue

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

Hi @sambolek. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[slavvka]

Hey @sambolek. Thank you for the fix. Please consider fixing the failed static tests even if you didn't touch the failing code. We would appreciate that. You can use this guide https://devdocs.magento.com/guides/v2.2/coding-standards/docblock-standard-general.html

[magento-engcom-team]

Hi @slavvka, thank you for the review.
ENGCOM-3074 has been created to process this Pull Request

[magento-engcom-team]

Hi @sambolek. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

[slavvka]

Hi @sambolek, we need the fix to be delivered also to 2.2-develop branch so please don't forget to port this PR to 2.2-develop; you can do it easily using the Porting Tool, https://devdocs.magento.com/guides/v2.2/contributor-guide/contributing.html#porting-tool