-
Notifications
You must be signed in to change notification settings - Fork 9.4k
fix: reset search mini-form when we have no data / an empty response #18055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @DanielRuf. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
@magento-engcom-team give me test instance |
|
Hi @phoenix128. Thank you for your request. I'm working on Magento instance for you |
|
Hi @phoenix128, here is your new Magento instance. |
phoenix128
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @DanielRuf ;
thank you for this contribution and for your ime, please check my review.
|
Hi @phoenix128, thank you for the review. |
|
Hi @DanielRuf. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Description
Currently the search form does not reset the results when we have no result / data.
Fixed Issues (if relevant)
Manual testing scenarios
pulloverin the searchenso we havepulloverenContribution checklist