Skip to content

Conversation

@gelanivishal
Copy link
Contributor

Original Pull request

#16924

Replacing usage of deprecated methods for message manager.

Description

Changes:

  • addSuccess -> addSuccessMessage;
  • addError -> addErrorMessage;
  • addException -> addExceptionMessage;
  • addWarning -> addWarningMessage;

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@sidolov
Copy link
Contributor

sidolov commented Aug 6, 2018

Hi @gelanivishal , due to changes in Magento Code Contributions Guide we can't accept such Pull Requests to 2.1 release line. All code cleanup like typos, spelling mistakes, removing unused code, etc should be delivered to 2.3 release line.
Thank you!

@sidolov sidolov closed this Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants