Skip to content

Conversation

@torhoehn
Copy link
Contributor

Original Pull Request

#16965
…et form

Description

Currently the forms for "create account" and "password forget" do not have the notice for the required fields. This PR adds it.

Fixed Issues (if relevant)

  1. ...

Manual testing scenarios

  1. go to /customer/account/create/ and /customer/account/forgotpassword/

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Basecom partners-contribution Pull Request is created by Magento Partner labels Jul 23, 2018
@magento-engcom-team
Copy link
Contributor

Hi @torhoehn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ihor-sviziev
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, here is your new Magento instance.
Admin access: https://pr-17041.engcom.dev.magento.com/admin
Login: admin Password: 123123q

@ihor-sviziev
Copy link
Contributor

Tested manually, works good

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2487 has been created to process this Pull Request

@sidolov
Copy link
Contributor

sidolov commented Jul 24, 2018

@torhoehn , I'm closing this PR as a duplicate of #17060 created by the author of original PR.

@sidolov sidolov closed this Jul 24, 2018
@torhoehn torhoehn deleted the 2.3-develop-PR-port-16965 branch July 24, 2018 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants