Skip to content

Conversation

@gelanivishal
Copy link
Contributor

@gelanivishal gelanivishal commented Jul 20, 2018

Original PR: #15360

Description:

Resolved product tier price pagination loader issue in admin.
The issue was reproduced in Magento 2.2-develop branch.

Fixed Issues

  1. Advanced pricing pagination issue #15210: Advanced pricing pagination issue

Manual testing scenarios

Navigate Admin => Catalog => Products => Create New / Edit Product.

  1. Go to Advanced Pricing link under Price text field.
  2. Add tier price more than a page and do save.
  3. Jump to other pages by directly editing the pagination text box.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2430 has been created to process this Pull Request

@sidolov
Copy link
Contributor

sidolov commented Jul 23, 2018

Hi @gelanivishal , we can't reproduce this issue on 2.1-develop branch.

Steps to reproduce:

  1. Create a simple product.
  2. Go to Advanced Pricing.
  3. Add tier price(more than 20).
  4. Jump to other pages by directly editing the pagination text box.

Result:
Requested page is opened.

16951

@ihor-sviziev
Copy link
Contributor

Hi @gelanivishal,
I'm closing this PR due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants