[Backport] Fix responsive tables showing broken heading #16830
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#16517
Description
When no heading is present in the
data-th
attribute on a column for a responsive table in Magento, a blank colon is present. This is easily fixed by only showing the before css on an element with thedata-th
attribute present.Before: http://take.ms/SoSdA
After: http://take.ms/KlVrK
Manual testing scenarios
Use the following markup on a blank or luma theme:
Contribution checklist