From cdb17cded5e34a82ac11963e24545e8361833d03 Mon Sep 17 00:00:00 2001 From: PhoenixPM - BK Date: Tue, 26 Jun 2018 18:15:54 +0200 Subject: [PATCH 1/2] fixed type hints and docs for samples block --- .../Downloadable/Block/Catalog/Product/Samples.php | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/app/code/Magento/Downloadable/Block/Catalog/Product/Samples.php b/app/code/Magento/Downloadable/Block/Catalog/Product/Samples.php index 120c7a38a8f41..4a03e975d8a4a 100644 --- a/app/code/Magento/Downloadable/Block/Catalog/Product/Samples.php +++ b/app/code/Magento/Downloadable/Block/Catalog/Product/Samples.php @@ -6,7 +6,8 @@ namespace Magento\Downloadable\Block\Catalog\Product; -use Magento\Downloadable\Model\ResourceModel\Sample; +use Magento\Downloadable\Model\ResourceModel\Sample\Collection as SampleCollection; +use Magento\Downloadable\Api\Data\SampleInterface; /** * Downloadable Product Samples part block @@ -29,7 +30,7 @@ public function hasSamples() /** * Get downloadable product samples * - * @return array + * @return SampleCollection */ public function getSamples() { @@ -37,10 +38,10 @@ public function getSamples() } /** - * @param Sample $sample + * @param SampleInterface $sample * @return string */ - public function getSampleUrl($sample) + public function getSampleUrl(SampleInterface $sample) { return $this->getUrl('downloadable/download/sample', ['sample_id' => $sample->getId()]); } From 9b8e91d6148708aede4c56ffbec1fda16cf99d4f Mon Sep 17 00:00:00 2001 From: Stanislav Idolov Date: Thu, 12 Jul 2018 15:44:31 +0300 Subject: [PATCH 2/2] Removed strict type due to BC --- app/code/Magento/Downloadable/Block/Catalog/Product/Samples.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/Downloadable/Block/Catalog/Product/Samples.php b/app/code/Magento/Downloadable/Block/Catalog/Product/Samples.php index 4a03e975d8a4a..859d6a53d0618 100644 --- a/app/code/Magento/Downloadable/Block/Catalog/Product/Samples.php +++ b/app/code/Magento/Downloadable/Block/Catalog/Product/Samples.php @@ -41,7 +41,7 @@ public function getSamples() * @param SampleInterface $sample * @return string */ - public function getSampleUrl(SampleInterface $sample) + public function getSampleUrl($sample) { return $this->getUrl('downloadable/download/sample', ['sample_id' => $sample->getId()]); }