Skip to content

[Forwardport] Added 'title' attribute to 'img' tag in knockout template files. #16769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2018
Merged

[Forwardport] Added 'title' attribute to 'img' tag in knockout template files. #16769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/Magento/Braintree/view/frontend/web/template/payment/paypal.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
data-bind="attr: {'id': getCode()}, value: getCode(), checked: isChecked, click: selectPaymentMethod, visible: isRadioButtonVisible()" />
<label class="label" data-bind="attr: {'for': getCode()}">
<!-- PayPal Logo -->
<img data-bind="attr: {src: getPaymentAcceptanceMarkSrc(), alt: $t('Acceptance Mark')}"
<img data-bind="attr: {src: getPaymentAcceptanceMarkSrc(), alt: $t('Acceptance Mark')}, title: $t('Acceptance Mark')}"
class="payment-icon"/>
<!-- PayPal Logo -->
<span text="getTitle()"></span>
Expand Down
1 change: 1 addition & 0 deletions app/code/Magento/Captcha/view/frontend/web/template/checkout/captcha.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
<div class="control captcha-image">
<img data-bind="attr: {
alt: $t('Please type the letters and numbers below'),
title: $t('Please type the letters and numbers below'),
height: imageHeight(),
src: getImageSource(),
}"
Expand Down
3 changes: 2 additions & 1 deletion app/code/Magento/Catalog/view/adminhtml/web/template/image-preview.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
event="load: $parent.onPreviewLoad.bind($parent)"
attr="
src: $parent.getFilePreview($file),
alt: $file.name">
alt: $file.name,
title: $file.name">
</a>

<div class="actions">
Expand Down
1 change: 1 addition & 0 deletions app/code/Magento/Catalog/view/base/web/template/product/list/columns/image.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
class="product-image-photo"
attr="src: getImageUrl($row()),
alt: getLabel($row()),
title: getLabel($row()),
width: getResizedImageWidth($row()),
height: getResizedImageHeight($row())"/>
</a>
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Catalog/view/base/web/template/product/list/columns/image_with_borders.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
data-bind="style: {'padding-bottom': getHeight($row())/getWidth($row()) * 100 + '%'}">
<img class="product-image-photo"
data-bind="attr: {src: getImageUrl($row()),
alt: getLabel($row())}" />
alt: getLabel($row()), title: getLabel($row())}" />
</span>
</span>
</a>
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Checkout/view/frontend/web/template/summary/item/details/thumbnail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@
data-bind="attr: {'style': 'height: ' + getHeight($parents[1]) + 'px; width: ' + getWidth($parents[1]) + 'px;' }">
<span class="product-image-wrapper">
<img
data-bind="attr: {'src': getSrc($parents[1]), 'width': getWidth($parents[1]), 'height': getHeight($parents[1]), 'alt': getAlt($parents[1]) }"/>
data-bind="attr: {'src': getSrc($parents[1]), 'width': getWidth($parents[1]), 'height': getHeight($parents[1]), 'alt': getAlt($parents[1]), 'title': getAlt($parents[1]) }"/>
</span>
</span>