From 905616833ecbfb40e143cbb1163cfb778c1217b2 Mon Sep 17 00:00:00 2001 From: alojua Date: Fri, 18 May 2018 15:05:46 +0200 Subject: [PATCH 1/2] forgot to add lowercase conversion on grouped product assignation after changes done in MAGETWO-67240 - See changes done for MAGETWO-67240 here https://github.com/magento/magento2/commit/02596b720fab5bd01fbc8026a1392c4971f78fed#diff-b876c962d83b3bee42acba83af842309 --- .../GroupedImportExport/Model/Import/Product/Type/Grouped.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/GroupedImportExport/Model/Import/Product/Type/Grouped.php b/app/code/Magento/GroupedImportExport/Model/Import/Product/Type/Grouped.php index 5547a59d291b7..83ffc3dfb253e 100644 --- a/app/code/Magento/GroupedImportExport/Model/Import/Product/Type/Grouped.php +++ b/app/code/Magento/GroupedImportExport/Model/Import/Product/Type/Grouped.php @@ -99,7 +99,7 @@ public function saveData() } $scope = $this->_entityModel->getRowScope($rowData); if (Product::SCOPE_DEFAULT == $scope) { - $productData = $newSku[$rowData[Product::COL_SKU]]; + $productData = $newSku[strtolower($rowData[Product::COL_SKU])]; } else { $colAttrSet = Product::COL_ATTR_SET; $rowData[$colAttrSet] = $productData['attr_set_code']; From 437844868c820f0ca1b81a5da3442be34a610085 Mon Sep 17 00:00:00 2001 From: hitesh-wagento Date: Thu, 12 Jul 2018 16:07:12 +0530 Subject: [PATCH 2/2] [Fix] forgot to add lowercase conversion on grouped product --- .../Model/Import/Product/Type/GroupedTest.php | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/app/code/Magento/GroupedImportExport/Test/Unit/Model/Import/Product/Type/GroupedTest.php b/app/code/Magento/GroupedImportExport/Test/Unit/Model/Import/Product/Type/GroupedTest.php index 88e640d3b8f04..b398b11d56e1a 100644 --- a/app/code/Magento/GroupedImportExport/Test/Unit/Model/Import/Product/Type/GroupedTest.php +++ b/app/code/Magento/GroupedImportExport/Test/Unit/Model/Import/Product/Type/GroupedTest.php @@ -217,26 +217,26 @@ public function testSaveDataProvider() 'skus' => [ 'newSku' => [ 'sku_assoc1' => ['entity_id' => 1], - 'productSku' => ['entity_id' => 3, 'attr_set_code' => 'Default', 'type_id' => 'grouped'] + 'productsku' => ['entity_id' => 3, 'attr_set_code' => 'Default', 'type_id' => 'grouped'] ], 'oldSku' => ['sku_assoc2' => ['entity_id' => 2]] ], 'bunch' => [ 'associated_skus' => 'sku_assoc1=1, sku_assoc2=2', - 'sku' => 'productSku', + 'sku' => 'productsku', 'product_type' => 'grouped' ] ], [ 'skus' => [ 'newSku' => [ - 'productSku' => ['entity_id' => 1, 'attr_set_code' => 'Default', 'type_id' => 'grouped'] + 'productsku' => ['entity_id' => 1, 'attr_set_code' => 'Default', 'type_id' => 'grouped'] ], 'oldSku' => [] ], 'bunch' => [ 'associated_skus' => '', - 'sku' => 'productSku', + 'sku' => 'productsku', 'product_type' => 'grouped' ] ], @@ -244,7 +244,7 @@ public function testSaveDataProvider() 'skus' => ['newSku' => [],'oldSku' => []], 'bunch' => [ 'associated_skus' => 'sku_assoc1=1, sku_assoc2=2', - 'sku' => 'productSku', + 'sku' => 'productsku', 'product_type' => 'grouped' ] ], @@ -252,13 +252,13 @@ public function testSaveDataProvider() 'skus' => [ 'newSku' => [ 'sku_assoc1' => ['entity_id' => 1], - 'productSku' => ['entity_id' => 3, 'attr_set_code' => 'Default', 'type_id' => 'grouped'] + 'productsku' => ['entity_id' => 3, 'attr_set_code' => 'Default', 'type_id' => 'grouped'] ], 'oldSku' => [] ], 'bunch' => [ 'associated_skus' => 'sku_assoc1=1', - 'sku' => 'productSku', + 'sku' => 'productsku', 'product_type' => 'simple' ] ] @@ -272,7 +272,7 @@ public function testSaveDataScopeStore() { $this->entityModel->expects($this->once())->method('getNewSku')->will($this->returnValue([ 'sku_assoc1' => ['entity_id' => 1], - 'productSku' => ['entity_id' => 2, 'attr_set_code' => 'Default', 'type_id' => 'grouped'] + 'productsku' => ['entity_id' => 2, 'attr_set_code' => 'Default', 'type_id' => 'grouped'] ])); $this->entityModel->expects($this->once())->method('getOldSku')->will($this->returnValue([ 'sku_assoc2' => ['entity_id' => 3] @@ -282,7 +282,7 @@ public function testSaveDataScopeStore() $bunch = [[ 'associated_skus' => 'sku_assoc1=1, sku_assoc2=2', - 'sku' => 'productSku', + 'sku' => 'productsku', 'product_type' => 'grouped' ]]; $this->entityModel->expects($this->at(2))->method('getNextBunch')->will($this->returnValue($bunch));