-
Notifications
You must be signed in to change notification settings - Fork 9.4k
$block->getTotals() is not countable #16563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…/view/adminhtml/templates/order/totalbar.php
|
Hi @MoT3rror. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
@MoT3rror is this issue reproducible in |
|
I can reproduce this issue on Magento 2.3 Alpha and have created issue #16653 for this. However the changes introduced in this PR are not resolving the issue. It will display some totals in a weird place which should not be displayed there. Please see attached screenshot below. |
|
Closing in favor of #16656 |

Description
Fix issue where $block->getTotals() is not countable in Magento/Sales/view/adminhtml/templates/order/totalbar.php
getTotals() is set to protected in block not allowing template to access the method.
Manual testing scenarios
Contribution checklist