Skip to content

Conversation

@Jeroenll
Copy link
Member

@Jeroenll Jeroenll commented Jul 5, 2018

Description

Add missing translations found in https://github.com/magento/magento2/blob/2.2-develop/app/code/Magento/Checkout/view/frontend/web/template/minicart/content.html

Fixed Issues (if relevant)

  1. None I could find.

Manual testing scenarios

  1. Install language pack other than English.
  2. Check translations in mini cart.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@Jeroenll Jeroenll added Release Line: 2.2 partners-contribution Pull Request is created by Magento Partner Partner: Reach Digital Pull Request is created by partner Reach Digital Partner: H&O labels Jul 5, 2018
@magento-engcom-team
Copy link
Contributor

Hi @JeroenVanLeusden. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@Jeroenll Jeroenll changed the title Update checkout translations Update mini-cart checkout translations Jul 5, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.6 milestone Jul 5, 2018
@magento-engcom-team magento-engcom-team merged commit d1c0ec3 into magento:2.2-develop Jul 7, 2018
@magento-engcom-team
Copy link
Contributor

Hi @JeroenVanLeusden. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@Jeroenll Jeroenll deleted the JeroenVanLeusden-patch-2 branch July 9, 2018 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Checkout Partner: H&O Partner: Reach Digital Pull Request is created by partner Reach Digital partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants