Skip to content

Format the javascript code in Tax module #16124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 19 commits into from
Closed

Format the javascript code in Tax module #16124

wants to merge 19 commits into from

Conversation

@gelanivishal
Copy link
Contributor

@gelanivishal gelanivishal commented Jun 14, 2018

Original Pull Request

#15343

Description

Refactor javascript validate code in Tax module.

Fixed Issues (if relevant)

  1. Reformat the javascript code as per magento standards. #15352: Reformat the javascript code as per magento standards

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

gelanivishal and others added 19 commits May 23, 2018 14:28
@gelanivishal
Merge pull request #2 from vgelani/2.1-develop-PR-port-15372
9478138 
[Backport] Fixed Purchased Order Form button should visible properly
@gelanivishal
Merge pull request #5 from vgelani/2.1-develop-PR-port-15398
9400075 
[Backport] Fixed set template syntax issue
@gelanivishal
Merge branch '2.1-develop' of https://github.com/vgelani/magento2 int…
ec03b6d 
…o 2.1-develop
@gelanivishal
Merge pull request #8 from vgelani/2.1-develop-PR-port-15421
0967f9d 
[Backport] Updated font-size variable and standardize #ToDo UI
@gelanivishal
Merge pull request #10 from vgelani/2.1-develop-PR-port-15416
689cb43 
[Backport] Moved css from media #TODO
@gelanivishal
Merge pull request #12 from vgelani/2.1-develop-PR-port-15549
e55cdca 
[Backport] Fixed typo error
@sanjay-wagento @gelanivishal
magento#14063 - Wrong invoice prefix in multistore setup due to defau…
c308795 
…lt store id
@gelanivishal
Merge pull request #14 from vgelani/2.1-develop-PR-port-15332
634b957 
[Backport] magento#14063 - Wrong invoice prefix in multistore setup due to default stor…
@gelanivishal
Merge pull request #16 from vgelani/2.1-develop-PR-port-15602
2d936be 
[Backport] set correct annotation
@gelanivishal
Merge pull request #17 from vgelani/2.1-develop-PR-port-15336
a5fa6e3 
[Backport] magento#12820 - Wrong annotation in _toOptionArray - magento/framework/Data/…
@EliasKotlyar @gelanivishal
Fixxes magento#15565
b04093c
@gelanivishal
Fixed coding standard error
486c5d4
@gelanivishal
Merge pull request #22 from vgelani/2.1-develop-PR-port-15566
c8ecee0 
[Backport] Fixxes magento#15565
@gelanivishal
Merge remote-tracking branch 'upstream/2.1-develop' into 2.1-develop
b62d330
@gelanivishal
Merge pull request #26 from vgelani/2.1-develop-PR-port-15892
7136c3a 
[Backport] Wrong annotation in _toOptionArray : lib\internal\Magento\Framework\D…
@gelanivishal
Merge pull request #28 from vgelani/2.1-develop-PR-port-15322
7ca71cc 
[Backport] ISSUE-11477 - fixed Swagger response for searchCriteria
@gelanivishal
Refactor validate code in Tax module
e4b77eb
@gelanivishal
Fixed semicolon issue
dcc10e9
@gelanivishal
Fixed coding standard issue
4d67269
@orlangur orlangur self-assigned this Jun 14, 2018
@orlangur orlangur added this to the Release: 2.1.15 milestone Jun 14, 2018
@orlangur
Copy link
Contributor

orlangur commented Jun 14, 2018

Commit history is incorrect. Please check it prior to PR creation.

@orlangur orlangur closed this Jun 14, 2018
@gelanivishal gelanivishal deleted the 2.1-develop-PR-back-15343 branch June 20, 2018 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@orlangur orlangur

Labels

Area: Design/Frontend Area: Frontend Component: Sales Component: Store Component: Tax Component: Webapi Use with concrete module component label E.g. "Component: Webapi" + "Catalog" Progress: reject

Projects

None yet

Milestone

Release: 2.1.15

Development

Successfully merging this pull request may close these issues.

5 participants

@gelanivishal @orlangur @magento-engcom-team @sanjay-wagento @EliasKotlyar