Skip to content

Fixed a minor styling issue in page footer in order to align the columns indentations #16026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2018
Merged

Fixed a minor styling issue in page footer in order to align the columns indentations #16026

merged 1 commit into from
Jun 13, 2018

Conversation

@dmytro-ch
Copy link
Contributor

@dmytro-ch dmytro-ch commented Jun 11, 2018 •
edited by sanganinamrata
Loading

Fixed a minor styling issue in page footer in order to align the columns indentations.

Description

The issue can be reproduced in 2.1-develop branch with sample data.

Before:
screen shot 2018-06-11 at 8 09 25 pm

After:
screen shot 2018-06-11 at 8 09 11 pm

Please note: The issue has been already fixed for 2.2 and 2.3 versions.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmytro-ch dmytro-ch added Release Line: 2.1 partners-contribution Pull Request is created by Magento Partner Partner: Atwix Pull Request is created by partner Atwix labels Jun 11, 2018
@dmytro-ch dmytro-ch requested a review from rogyar June 11, 2018 17:48
@magento-engcom-team magento-engcom-team added this to the Release: 2.1.15 milestone Jun 11, 2018
@magento-engcom-team magento-engcom-team merged commit caee053 into magento:2.1-develop Jun 13, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 13, 2018
ENGCOM-1947: Fixed a minor styling issue in page footer in order to a…
7d2402c 
…lign the columns indentations #16026
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jun 13, 2018

Hi @dmytro-ch. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.1.15 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rogyar rogyar Awaiting requested review from rogyar

Assignees

@rogyar rogyar

Labels

Area: Design/Frontend Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.1

Projects

None yet

Milestone

Release: 2.1.15

Development

Successfully merging this pull request may close these issues.

3 participants

@dmytro-ch @magento-engcom-team @rogyar