Skip to content

Conversation

@Karlasa
Copy link
Contributor

@Karlasa Karlasa commented Jun 11, 2018

Description

On smaller screens checkout page cart icon didn't had hover color and regular color was not implemented through correct variable. (Should be button color, not primary color)

Manual testing scenarios

  1. Go to checkout page
  2. scale screen down - to see cart icon
  3. move mouse over cart icon

Expected result

cart icon color changes

Actual result

cart icon color stays same

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@Karlasa Karlasa deleted the checkout-icon-fix branch June 16, 2018 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants