Skip to content

Conversation

@dankhrapiyush
Copy link
Contributor

Original Pull Request

#15365

Trim email address on customer account login page generally when copy and paste.

Description

Trim email address by remove leading or trailing space on the customer account login page email field.

Fixed Issues (if relevant)

  1. IE11 user login email validation fails if field has leading or trailing space #6058: IE11 user login email validation fails if field has leading or trailing space

Manual testing scenarios

  1. Open customer account login page in Firefox or IE browser.
  2. Try to add space before entering an email address in the Email field.
  3. Copy " [email protected] " and paste in the Email field. It will automatically remove leading or trailing space.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ihor-sviziev ihor-sviziev reopened this Jun 8, 2018
@ihor-sviziev
Copy link
Contributor

I closed and re-opened PR in order to restart build on travis

@dankhrapiyush
Copy link
Contributor Author

@ihor-sviziev Okay
In original PR, it was not completed as well.

Thank you.

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-1930 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @dankhrapiyush. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.1.15 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants