Skip to content

Conversation

@sanjay-wagento
Copy link
Contributor

Original Pull Request

#14914

Description

\Magento\Sales\Model\Order\Config::getStatusLabel(), used by template email was forcing the usage of getLabel() when in adminhtml area.
I added a new method getFrontendStatusLabel() in \Magento\Sales\Model\Order and modified email template files to use it instead of the original implementation.
I did not modify the original implementation because still in use by backend and frontend.

Fixed Issues (if relevant)

  1. In Sales Emails no translation using order.getStatusLabel()  #14849: In Sales Emails no translation using order.getStatusLabel()

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

phoenix128 and others added 3 commits June 4, 2018 11:36
…StatusLabel() \Magento\Sales\Model\Order\Config::getStatusLabel(), used by template email was forcing the usage of getLabel() when in adminhtml area. I added a new method getFrontendStatusLabel() in \Magento\Sales\Model\Order and modified email template files to use it instead of the original implementation. I did not modify the original implementation because still in use by backend and frontend.
@sivaschenko
Copy link
Member

@VladimirZaets removing "on hold" label as the original pull request was merged.

@VladimirZaets
Copy link
Contributor

Hi @sanjay-wagento. The original PR was merged, but the code in your PR is outdated. Please update the code according to original PR. Thanks!

@VladimirZaets
Copy link
Contributor

Hi @sanjay-wagento, I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for collaboration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants