Skip to content

Conversation

@dmytro-ch
Copy link
Contributor

Original Pull Request

#15240

Description

The Export model have some unused namespaces: Magento\Framework\Filesystem\Directory\WriteInterface.
Just removing it and update description

Manual testing scenarios

  1. For example, go to orders list;
  2. Export list of order by XML or CSV;
  3. All should export as expected.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmytro-ch dmytro-ch requested a review from rogyar May 31, 2018 04:39
@dmytro-ch dmytro-ch added Release Line: 2.2 partners-contribution Pull Request is created by Magento Partner Partner: Atwix Pull Request is created by partner Atwix labels May 31, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.6 milestone May 31, 2018
{
/**
* @var WriteInterface
* @var DirectoryList
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there's some mistake. In the constructor we init $directory property as a result of $filesystem->getDirectoryWrite() method, which creates an instance of Magento\Framework\Filesystem\Directory\Write using the corresponding factory. So, basically, it returns WriteInterface but not DirectoryList. The same situation is for the ConvertToXml class.
Please, correct me if I'm wrong.

@dmytro-ch
Copy link
Contributor Author

dmytro-ch commented Jun 2, 2018

@rogyar thank you for notice. You are right. We should close this pull request.

@dmytro-ch dmytro-ch closed this Jun 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Ui Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: needs update Release Line: 2.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants