Skip to content

[Forwardport] Removed duplicate line and added comment on variable #15561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 29, 2018
Merged

[Forwardport] Removed duplicate line and added comment on variable #15561

merged 2 commits into from
May 29, 2018

Conversation

@gelanivishal
Copy link
Contributor

@gelanivishal gelanivishal commented May 29, 2018 •
edited by sidolov
Loading

Original Pull Request

#15362

Description

Removed duplicate code and added comment on variable.

Fixed Issues (if relevant)

  1. N/A

Manual testing scenarios

  1. N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@gelanivishal gelanivishal changed the title Removed duplicate line and added comment on variable [Forwardport] Removed duplicate line and added comment on variable May 29, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone May 29, 2018
@magento-engcom-team magento-engcom-team merged commit f9a86bc into magento:2.3-develop May 29, 2018
magento-engcom-team pushed a commit that referenced this pull request May 29, 2018
ENGCOM-1695: [Forwardport] Removed duplicate line and added comment o…
df35953 
…n variable #15561
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented May 29, 2018

Hi @vgelani. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sidolov sidolov

Labels

Component: Sales Progress: accept Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@gelanivishal @magento-engcom-team @sidolov