diff --git a/app/code/Magento/Catalog/view/frontend/web/js/product/breadcrumbs.js b/app/code/Magento/Catalog/view/frontend/web/js/product/breadcrumbs.js index d3596cdd100ec..032b8541939c3 100644 --- a/app/code/Magento/Catalog/view/frontend/web/js/product/breadcrumbs.js +++ b/app/code/Magento/Catalog/view/frontend/web/js/product/breadcrumbs.js @@ -20,23 +20,6 @@ define([ menuContainer: '[data-action="navigation"] > ul' }, - /** @inheritdoc */ - _init: function () { - var menu, - originalInit = this._super.bind(this); - - // render breadcrumbs after navigation menu is loaded. - menu = $(this.options.menuContainer).data('mageMenu'); - - if (typeof menu === 'undefined') { - $(this.options.menuContainer).on('menucreate', function () { - originalInit(); - }); - } else { - this._super(); - } - }, - /** @inheritdoc */ _render: function () { this._appendCatalogCrumbs(); @@ -89,14 +72,10 @@ define([ * @private */ _getCategoryCrumb: function (menuItem) { - var categoryId = /(\d+)/i.exec(menuItem.attr('id'))[0], - categoryName = menuItem.text(), - categoryUrl = menuItem.attr('href'); - return { - 'name': 'category' + categoryId, - 'label': categoryName, - 'link': categoryUrl, + 'name': 'category', + 'label': menuItem.text(), + 'link': menuItem.attr('href'), 'title': '' }; }, diff --git a/dev/tests/js/jasmine/tests/app/code/Magento/Catalog/frontend/js/product/breadcrumbs.test.js b/dev/tests/js/jasmine/tests/app/code/Magento/Catalog/frontend/js/product/breadcrumbs.test.js index 2b0ee8ca7b9c0..2d8f145bce1da 100644 --- a/dev/tests/js/jasmine/tests/app/code/Magento/Catalog/frontend/js/product/breadcrumbs.test.js +++ b/dev/tests/js/jasmine/tests/app/code/Magento/Catalog/frontend/js/product/breadcrumbs.test.js @@ -20,7 +20,7 @@ define([ defaultContext = require.s.contexts._, menuItem = $( '
  • ' + - 'Cat1' + + 'Cat1' + '
  • ' )[0], @@ -116,14 +116,14 @@ define([ }); it('Check _getCategoryCrumb call', function () { - var item = $('Cat1'); + var item = $('Cat1'); expect(widget).toBeDefined(); expect(widget).toEqual(jasmine.any(Function)); expect(widget.prototype._getCategoryCrumb).toBeDefined(); expect(widget.prototype._getCategoryCrumb(item)).toEqual(jasmine.objectContaining( { - 'name': 'category3', + 'name': 'category', 'label': 'Cat1', 'link': 'http://localhost.com/cat1.html' } @@ -232,7 +232,7 @@ define([ expect(result.length).toBe(1); expect(result[0]).toEqual(jasmine.objectContaining( { - 'name': 'category3', + 'name': 'category', 'label': 'Cat1', 'link': 'http://localhost.com/cat1.html' } @@ -243,10 +243,10 @@ define([ var result, menuItems = $( '' @@ -262,14 +262,14 @@ define([ context = createContext(widget.prototype); getParentMenuHandler = widget.prototype._getParentMenuItem.bind(context); - result = getParentMenuHandler($('#ui-id-9')); + result = getParentMenuHandler($('[href="http://localhost.com/cat1/cat21.html"]')); expect(result).toBeDefined(); expect(result.length).toBe(1); expect(result[0].tagName.toLowerCase()).toEqual('a'); - expect(result.attr('id')).toEqual('ui-id-3'); + expect(result.attr('href')).toEqual('http://localhost.com/cat1.html'); - result = getParentMenuHandler($('#ui-id-3')); + result = getParentMenuHandler($('[href="http://localhost.com/cat1.html"]')); expect(result).toBeNull(); });