From d2a3b1c575fd4dad54e4df99d4ea07303f8f323a Mon Sep 17 00:00:00 2001 From: Yogesh Suhagiya Date: Sat, 19 May 2018 11:47:42 +0530 Subject: [PATCH 1/4] Added language translation for message string --- .../Controller/Adminhtml/System/Message/ListAction.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/code/Magento/AdminNotification/Controller/Adminhtml/System/Message/ListAction.php b/app/code/Magento/AdminNotification/Controller/Adminhtml/System/Message/ListAction.php index 68de06c1c22bd..6c9578a703987 100644 --- a/app/code/Magento/AdminNotification/Controller/Adminhtml/System/Message/ListAction.php +++ b/app/code/Magento/AdminNotification/Controller/Adminhtml/System/Message/ListAction.php @@ -61,8 +61,10 @@ public function execute() if (empty($result)) { $result[] = [ 'severity' => (string)\Magento\Framework\Notification\MessageInterface::SEVERITY_NOTICE, - 'text' => 'You have viewed and resolved all recent system notices. ' - . 'Please refresh the web page to clear the notice alert.', + 'text' => __( + 'You have viewed and resolved all recent system notices. ' + . 'Please refresh the web page to clear the notice alert.' + ) ]; } $this->getResponse()->representJson($this->jsonHelper->jsonEncode($result)); From 9d01d76afb05699c596063a1526341e3be05e17c Mon Sep 17 00:00:00 2001 From: Yogesh Suhagiya Date: Sat, 19 May 2018 12:49:56 +0530 Subject: [PATCH 2/4] Format the code --- .../Controller/Adminhtml/System/Message/ListAction.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/code/Magento/AdminNotification/Controller/Adminhtml/System/Message/ListAction.php b/app/code/Magento/AdminNotification/Controller/Adminhtml/System/Message/ListAction.php index 6c9578a703987..f74a2907b318f 100644 --- a/app/code/Magento/AdminNotification/Controller/Adminhtml/System/Message/ListAction.php +++ b/app/code/Magento/AdminNotification/Controller/Adminhtml/System/Message/ListAction.php @@ -61,10 +61,10 @@ public function execute() if (empty($result)) { $result[] = [ 'severity' => (string)\Magento\Framework\Notification\MessageInterface::SEVERITY_NOTICE, - 'text' => __( - 'You have viewed and resolved all recent system notices. ' - . 'Please refresh the web page to clear the notice alert.' - ) + 'text' => __( + 'You have viewed and resolved all recent system notices. ' + . 'Please refresh the web page to clear the notice alert.' + ) ]; } $this->getResponse()->representJson($this->jsonHelper->jsonEncode($result)); From 8efc333d8f595ece59cb12f00db204a652c1b101 Mon Sep 17 00:00:00 2001 From: Yogesh Suhagiya Date: Sun, 20 May 2018 09:14:03 +0530 Subject: [PATCH 3/4] Added language translation key --- app/code/Magento/AdminNotification/i18n/en_US.csv | 1 + 1 file changed, 1 insertion(+) diff --git a/app/code/Magento/AdminNotification/i18n/en_US.csv b/app/code/Magento/AdminNotification/i18n/en_US.csv index 7b55e96976cad..bc157298a021a 100644 --- a/app/code/Magento/AdminNotification/i18n/en_US.csv +++ b/app/code/Magento/AdminNotification/i18n/en_US.csv @@ -49,3 +49,4 @@ Severity,Severity "Date Added","Date Added" Message,Message Actions,Actions +"You have viewed and resolved all recent system notices. Please refresh the web page to clear the notice alert.","You have viewed and resolved all recent system notices. Please refresh the web page to clear the notice alert." \ No newline at end of file From 002a7c09b18db57027fecebceebeb41743f85c88 Mon Sep 17 00:00:00 2001 From: Yogesh Suhagiya Date: Sun, 20 May 2018 09:15:52 +0530 Subject: [PATCH 4/4] Added language translation key --- app/code/Magento/AdminNotification/i18n/en_US.csv | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/AdminNotification/i18n/en_US.csv b/app/code/Magento/AdminNotification/i18n/en_US.csv index bc157298a021a..8f780efa6c184 100644 --- a/app/code/Magento/AdminNotification/i18n/en_US.csv +++ b/app/code/Magento/AdminNotification/i18n/en_US.csv @@ -49,4 +49,4 @@ Severity,Severity "Date Added","Date Added" Message,Message Actions,Actions -"You have viewed and resolved all recent system notices. Please refresh the web page to clear the notice alert.","You have viewed and resolved all recent system notices. Please refresh the web page to clear the notice alert." \ No newline at end of file +"You have viewed and resolved all recent system notices. Please refresh the web page to clear the notice alert.","You have viewed and resolved all recent system notices. Please refresh the web page to clear the notice alert."