From 6e57b657f2f05ad54927c116b941086f61c11a4e Mon Sep 17 00:00:00 2001 From: Jon Shipman Date: Fri, 18 May 2018 13:42:46 -0500 Subject: [PATCH 1/2] Scope issue with previous for and i variable --- .../view/adminhtml/web/js/category-checkbox-tree.js | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/app/code/Magento/Catalog/view/adminhtml/web/js/category-checkbox-tree.js b/app/code/Magento/Catalog/view/adminhtml/web/js/category-checkbox-tree.js index abe9f626eb8b6..2edf51a0168bf 100644 --- a/app/code/Magento/Catalog/view/adminhtml/web/js/category-checkbox-tree.js +++ b/app/code/Magento/Catalog/view/adminhtml/web/js/category-checkbox-tree.js @@ -162,14 +162,16 @@ define([ * @returns {void} */ categoryLoader.buildCategoryTree = function (parent, config) {// eslint-disable-line no-shadow + var i = 0; if (!config) { return null; } if (parent && config && config.length) { - for (i = 0; i < config.length; i++) { + while (i < config.length) { categoryLoader.processCategoryTree(parent, config, i); + i++; } } }; @@ -181,17 +183,21 @@ define([ * @returns {Object} */ categoryLoader.buildHashChildren = function (hash, node) {// eslint-disable-line no-shadow + var i = 0, len; + // eslint-disable-next-line no-extra-parens if ((node.childNodes.length > 0) || (node.loaded === false && node.loading === false)) { + len = node.childNodes.length; hash.children = []; - for (i = 0, len = node.childNodes.length; i < len; i++) { + while (i < len) { /* eslint-disable */ if (!hash.children) { hash.children = []; } /* eslint-enable */ hash.children.push(this.buildHash(node.childNodes[i])); + i++; } } From b8e7dbd30cef76bff25bff34cafd3202b5e717f4 Mon Sep 17 00:00:00 2001 From: Vishal Gelani Date: Sat, 19 May 2018 21:17:58 +0530 Subject: [PATCH 2/2] Fixed coding standard issue. --- .../Catalog/view/adminhtml/web/js/category-checkbox-tree.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/app/code/Magento/Catalog/view/adminhtml/web/js/category-checkbox-tree.js b/app/code/Magento/Catalog/view/adminhtml/web/js/category-checkbox-tree.js index 2edf51a0168bf..40272272623e5 100644 --- a/app/code/Magento/Catalog/view/adminhtml/web/js/category-checkbox-tree.js +++ b/app/code/Magento/Catalog/view/adminhtml/web/js/category-checkbox-tree.js @@ -32,9 +32,7 @@ define([ data = {}, parameters = {}, root = {}, - len = 0, - key = '', - i = 0; + key = ''; /* eslint-disable */ /**