From b7179ad97c0a406e41245d9d092a17df529a1768 Mon Sep 17 00:00:00 2001 From: Keith Bentrup Date: Wed, 16 May 2018 13:27:47 -0400 Subject: [PATCH] declare var to fix scope error By not declaring var i = 0, the code is referencing the i declared in the outer function. This causes an infinite loop condition that crashes browsers as multiple methods modify the value of i. --- .../Catalog/view/adminhtml/web/js/category-checkbox-tree.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/code/Magento/Catalog/view/adminhtml/web/js/category-checkbox-tree.js b/app/code/Magento/Catalog/view/adminhtml/web/js/category-checkbox-tree.js index abe9f626eb8b6..71d2ba9a6e101 100644 --- a/app/code/Magento/Catalog/view/adminhtml/web/js/category-checkbox-tree.js +++ b/app/code/Magento/Catalog/view/adminhtml/web/js/category-checkbox-tree.js @@ -168,7 +168,7 @@ define([ } if (parent && config && config.length) { - for (i = 0; i < config.length; i++) { + for (var i = 0; i < config.length; i++) { categoryLoader.processCategoryTree(parent, config, i); } } @@ -185,7 +185,7 @@ define([ if ((node.childNodes.length > 0) || (node.loaded === false && node.loading === false)) { hash.children = []; - for (i = 0, len = node.childNodes.length; i < len; i++) { + for (var i = 0, len = node.childNodes.length; i < len; i++) { /* eslint-disable */ if (!hash.children) { hash.children = [];