Skip to content

[Backport] Add statement to 'beforeSave' method to allow app:config:import #15066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2018
Merged

[Backport] Add statement to 'beforeSave' method to allow app:config:import #15066

merged 1 commit into from
May 10, 2018

Conversation

@rogyar
Copy link
Contributor

@rogyar rogyar commented May 8, 2018

Original PR: #14829

Fix to app:config:import for beforeSave method on Braintree CountryCreditCard class.

Description

magento@04065890c38d:/srv/magento2$ php bin/magento app:config:import
Processing configurations data from configuration file...
Import failed: Warning: Invalid argument supplied for foreach() in /srv/magento2/vendor/magento/module-braintree/Model/Adminhtml/System/Config/CountryCreditCard.php on line 70

Manual testing scenarios

  1. php bin/magento app:config:dump
  2. change some configs
  3. php bin/magento app:config:import

@VladimirZaets
Copy link
Contributor

VladimirZaets commented May 8, 2018

Hi, @rogyar , I took your PR into processing, thank you for collaboration.

@magento-engcom-team magento-engcom-team added this to the May 2018 milestone May 8, 2018
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept labels May 8, 2018
@magento-engcom-team magento-engcom-team merged commit a7e8b71 into magento:2.1-develop May 10, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented May 10, 2018

Hi @rogyar. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.1.15 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@VladimirZaets VladimirZaets

Labels

Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.1

Projects

None yet

Milestone

May 2018

Development

Successfully merging this pull request may close these issues.

3 participants

@rogyar @VladimirZaets @magento-engcom-team