Skip to content

Conversation

@chris-pook
Copy link
Contributor

This config name is notoriously misleading as it does not show the block name at all, instead it shows the block class type. Worse still there is a question about this in the Magento2 certification exam which is utterly confusing due to the poor naming of the config setting.

Description

I have updated the label of this config setting to state what it actually does when enabled, displaying the block class type on the hints.

Fixed Issues (if relevant)

n/a

Manual testing scenarios

  • Login to admin, view updated configuration label.
  • Set config to "Yes", confirm block class types are still being shown on template hints.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

This config name is notoriously misleading as it does not show the block name at all, instead it shows the block class type. Worse still there is a question about this in the Magento2 certification exam which is utterly confusing due to the poor naming of the config setting.
@magento-engcom-team
Copy link
Contributor

@chris-pook thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@VladimirZaets
Copy link
Contributor

Hi, @chris-pook , I took your PR into processing, thank you for collaboration.

@magento-engcom-team magento-engcom-team merged commit ace164b into magento:2.2-develop May 3, 2018
magento-engcom-team pushed a commit that referenced this pull request May 3, 2018
@magento-engcom-team
Copy link
Contributor

Hi @chris-pook. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants