Skip to content

Conversation

@namlier
Copy link
Contributor

@namlier namlier commented Apr 4, 2018

Original Pull Request

#12951
There appears to be a typo in this action.

Description

The Magento\Ui\Controller\Adminhtml\Index\Render action incorrectly calls _ instead of __. This resulted in an error when I was running unit tests. I've searched the codebase for other instances of _() but did not find any.

Fixed Issues (if relevant)

No issue.

Manual testing scenarios

I was not able to manually trigger this error. We spotted the error during our CI build:

Magento\Ui\Test\Unit\Controller\Adminhtml\Index\RenderTest::testExecuteAjaxRequestException
Error: Call to undefined function Magento\Ui\Controller\Adminhtml\Index\_()

/var/www/magento/vendor/magento/module-ui/Controller/Adminhtml/Index/Render.php:91
/var/www/magento/vendor/magento/module-ui/Controller/Adminhtml/AbstractAction.php:62
/var/www/magento/vendor/magento/module-ui/Test/Unit/Controller/Adminhtml/Index/RenderTest.php:226

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants