[FIX] Simplify ternary operators for catalog module

[coderimus]

Description

Hello,
Worked on the internal issue I have found that there is possible to simplify some ternary operators for catalog module. I would be happy to do this for all modules in future by phpcs-fixer automatically but as I can see it doesn't have such ability.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[adrian-martinez-interactiv4]

This change breaks expected functionality, try:

$cacheKey = $storeId ?? 'all';

[coderimus]

Hi @adrian-martinez-interactiv4 thank you for your detail review. I implemented requested fix and squashed commits to one. Please, review it.

[orlangur]

I would be happy to do this for all modules in future by php-cs-fixer automatically but as I can see it doesn't have such ability.

Just do it 😉 There is no reason to waste time on performing such changes manually.