Skip to content

Conversation

@barbazul
Copy link
Contributor

Also added test coverage to getSimpleQtyToShip and getQtyToInvoice

Description

I am using rounding to a large number of decimals (8) to orders that cannot be completed due to strict equal to zero comparisons on item qty

Fixed Issues (if relevant)

Fixes #14328

Manual testing scenarios

  1. Complete an order with a product using qty = 4.4
  2. Create an invoice for qty = 0.4
  3. Refund the invoice
  4. Create an invoice for qty = 4
  5. Create a shipment for qty = 4
  6. Order should be complete

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Added test coverage to getSimpleQtyToShip and getQtyToInvoice

Fixes 14328
@miguelbalparda miguelbalparda added the Event: distributed-cd Distributed Contribution Day label Mar 24, 2018
@rogyar rogyar self-assigned this Mar 25, 2018
Trying to keep the public method count below 11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants