From 094d555569db80b3f54edc89404de8557a0b05a4 Mon Sep 17 00:00:00 2001 From: Neill Robson Date: Fri, 16 Feb 2018 19:32:53 -0500 Subject: [PATCH] Fix faulty admin spinner animation When the @spinner-delay variable does not have a unit (s/seconds), the generated animation-delay attribute for the western spinner spoke also lacks a unit. In certain browsers (I am testing with Firefox Developer Edition 59.0b10 (64-bit)), this CSS style is marked as invalid and not applied, causing the western and south-western spokes of the spinner to flash out of order in the resulting animation. I assume that, somewhere in the LESS calculations, the @spinner-delay and @spinner-animation-step variables are combined with arithmetic, coercing the resulting spoke style to have the correct units: this coercion does not occur for the final spoke, perhaps because the arithmetic involved does not include the last child (for which the animation delay should be at a maximum). In any case, the error is hardly noticeable, but there's no reason to let such a easily-fixable styling omission slip through the cracks. --- .../Magento/backend/web/css/source/variables/_spinner.less | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/design/adminhtml/Magento/backend/web/css/source/variables/_spinner.less b/app/design/adminhtml/Magento/backend/web/css/source/variables/_spinner.less index 09baf498cbcf4..60b84b1f467fe 100644 --- a/app/design/adminhtml/Magento/backend/web/css/source/variables/_spinner.less +++ b/app/design/adminhtml/Magento/backend/web/css/source/variables/_spinner.less @@ -26,4 +26,4 @@ @spinner-rotate-step: 45; // One step in degree -@spinner-delay: .9; +@spinner-delay: .9s;