Performance: remove count() form the condition section of a loop #13173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihor-sviziev
approved these changes
Jan 14, 2018
Contributor
|
Hi @coderimus |
ishakhsuvarov
requested changes
Jan 15, 2018
| $expression = trim($expression); | ||
| foreach ($this->_operations as $operation) { | ||
| $splittedExpr = preg_split('/\\' . $operation . '/', $expression, -1, PREG_SPLIT_DELIM_CAPTURE); | ||
| if (count($splittedExpr) > 1) { |
Contributor
There was a problem hiding this comment.
I assume that old check would not pass if $splittedExpr is and array with 1 element, while new one would pass.
Contributor
Author
There was a problem hiding this comment.
@ishakhsuvarov thank you for your review! You are totally right. Fix uploaded.
Contributor
Author
|
@ishakhsuvarov requested changes added. Please, review them when this will be suitable for you :) |
Contributor
|
Thanks @coderimus |
ishakhsuvarov
approved these changes
Jan 18, 2018
ihor-sviziev
approved these changes
Feb 16, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Mar 9, 2018
This was referenced Mar 20, 2018
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR I removed the
count()method from condition section for some loops. When this method is used in the loop condition it will be executed every iteration which is not so good for process time (performance).Fixed Issues (if relevant)
N/A
Manual testing scenarios
N/A
Contribution checklist