Skip to content

Fix import grouped products #12853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2018
Merged

Fix import grouped products #12853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01013fa
Fix for issue 12793
Dec 21, 2017
b566ca7
Get newSku will return lowercase sku. fix unittest.
Dec 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/code/Magento/GroupedImportExport/Model/Import/Product/Type/Grouped.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ public function saveData()
foreach ($associatedSkusAndQtyPairs as $associatedSkuAndQty) {
++$position;
$associatedSkuAndQty = explode(self::SKU_QTY_DELIMITER, $associatedSkuAndQty);
$associatedSku = isset($associatedSkuAndQty[0]) ? trim($associatedSkuAndQty[0]) : null;
$associatedSku = isset($associatedSkuAndQty[0]) ? strtolower(trim($associatedSkuAndQty[0])) : null;
if (isset($newSku[$associatedSku])) {
$linkedProductId = $newSku[$associatedSku][$this->getProductEntityIdentifierField()];
} elseif (isset($oldSku[$associatedSku])) {
Expand All @@ -99,7 +99,7 @@ public function saveData()
}
$scope = $this->_entityModel->getRowScope($rowData);
if (Product::SCOPE_DEFAULT == $scope) {
$productData = $newSku[$rowData[Product::COL_SKU]];
$productData = $newSku[strtolower($rowData[Product::COL_SKU])];
} else {
$colAttrSet = Product::COL_ATTR_SET;
$rowData[$colAttrSet] = $productData['attr_set_code'];
Expand Down
6 changes: 3 additions & 3 deletions app/code/Magento/GroupedImportExport/Test/Unit/Model/Import/Product/Type/GroupedTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ public function saveDataProvider()
'skus' => [
'newSku' => [
'sku_assoc1' => ['entity_id' => 1],
'productSku' => ['entity_id' => 3, 'attr_set_code' => 'Default', 'type_id' => 'grouped']
'productsku' => ['entity_id' => 3, 'attr_set_code' => 'Default', 'type_id' => 'grouped']
],
'oldSku' => ['sku_assoc2' => ['entity_id' => 2]]
],
Expand All @@ -205,7 +205,7 @@ public function saveDataProvider()
[
'skus' => [
'newSku' => [
'productSku' => ['entity_id' => 1, 'attr_set_code' => 'Default', 'type_id' => 'grouped']
'productsku' => ['entity_id' => 1, 'attr_set_code' => 'Default', 'type_id' => 'grouped']
],
'oldSku' => []
],
Expand Down Expand Up @@ -247,7 +247,7 @@ public function testSaveDataScopeStore()
{
$this->entityModel->expects($this->once())->method('getNewSku')->will($this->returnValue([
'sku_assoc1' => ['entity_id' => 1],
'productSku' => ['entity_id' => 2, 'attr_set_code' => 'Default', 'type_id' => 'grouped']
'productsku' => ['entity_id' => 2, 'attr_set_code' => 'Default', 'type_id' => 'grouped']
]));
$this->entityModel->expects($this->once())->method('getOldSku')->will($this->returnValue([
'sku_assoc2' => ['entity_id' => 3]
Expand Down