-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[FIX] Magento_Ui: Return empty string when the given date column is undefined #12462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi, thank you for your PR! Please can you have a look at the failing travis build? Thanks! |
|
Good catch! I wasn't familiar with the JS linter. The build should go 💚 soon and I've already rebased to squash the commits. Thanks! |
|
Great, thanks for the quick fix! I'll let you know if the interal tests show any problems. The CET indicated in #12461 that this is fixed in |
|
I can confirm that the linked fix works correctly, so I guess that makes my PR useless :) FYI @ihor-sviziev Thanks! |
|
@tedsalmon I'll ask around to find out how the problem was fixed in |
|
The fix should just be this portion of the 2.3 code Thanks! |
|
@tedsalmon and me found out this is a duplicate of #11749 so I'm closing this one. It will be fixed in 2.2.2. |
|
FYI this issue was also fixed in 2.1-develop branch in #12033 |
Description
Return empty string when the given date column is undefined in a grid
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist