Simplified \Magento\Framework\Reflection\TypeProcessor #12324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YevSent
force-pushed
the
type-processor-simplification
branch
from
2b57f20 to
87917a9
Compare
- Removed `preg_match` usage for param description retrieving - Removed `preg_match` usage for param type retrieving
YevSent
force-pushed
the
type-processor-simplification
branch
from
87917a9 to
41dad0a
Compare
magento-engcom-team
pushed a commit
that referenced
this pull request
May 16, 2018
Contributor
|
Hi @joni-jones. Thank you for your contribution. |
4 tasks
Contributor
|
@joni-jones @sidolov forwardport maybe? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplified TypeProcessor methods to retrieve method param addition description and array param type
Testing scenarios
Covered by unit tests
Contribution checklist