From ffd2412378530623d80b88b24dbf1b586c1a1bd2 Mon Sep 17 00:00:00 2001 From: Danny Verkade Date: Sat, 7 Oct 2017 18:31:13 +0200 Subject: [PATCH] Resolved issue #9243: - Removed Magento\Framework\Locale\CurrencyInterface from setService method and changed it to \Zend_Currency_CurrencyInterface which must be provider to this function. - Changed return type to \Zend_Currency_CurrencyInterface, the given instance of the service is returned by the setService function - Removed \Zend_Service from getService method and changed it to \Zend_Currency_CurrencyInterface - Added @deprecated tags to both methods and added @see annotation to the methods. Referenced corresponding interface \Magento\Directory\Model\Currency\Import\ImportInterface --- lib/internal/Magento/Framework/CurrencyInterface.php | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/lib/internal/Magento/Framework/CurrencyInterface.php b/lib/internal/Magento/Framework/CurrencyInterface.php index 7242a724e05a7..4dbde431041fc 100644 --- a/lib/internal/Magento/Framework/CurrencyInterface.php +++ b/lib/internal/Magento/Framework/CurrencyInterface.php @@ -239,15 +239,19 @@ public function isLess($value, $currency = null); /** * Returns the set service class * - * @return \Zend_Service + * @return \Zend_Currency_CurrencyInterface + * @deprecated + * @see \Magento\Directory\Model\Currency\Import\ImportInterface */ public function getService(); /** * Sets a new exchange service * - * @param string|\Magento\Framework\Locale\CurrencyInterface $service Service class - * @return \Magento\Framework\CurrencyInterface + * @param string|\Zend_Currency_CurrencyInterface $service Service class + * @return \Zend_Currency_CurrencyInterface + * @deprecated + * @see \Magento\Directory\Model\Currency\Import\ImportInterface */ public function setService($service); }