Sample Files for Unsalable Products Redirect Instead of Download

[samuel-reinhardt]

Preconditions (*)

1. 2.4-develop
2. Set Stores->Catalog->Inventory->Stock Options->Display Out of Stock Products=Yes

Steps to reproduce (*)

1. Login to admin
2. Go to Catalog-->Products
3. Select 'Downloadable product' from 'Add product' button dropdown
4. Fill all required inputs
5. Set product status to 'Out to stock'
6. Go to 'Downloadable information' tab
7. Press 'Add link' button under a Samples
8. Add any test file
9. Save a product
10. Go to the product page on the frontend
11. Press on link under 'Samples'

Expected result (*)

1. By default, the sample file should be downloaded. Products that are not currently for sale should still allow customers to download samples.

Actual result (*)

1. New tab is opened. No download is started and no explanation is given.

[m2-assistant]

Hi @samuel-reinhardt. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@samuel-reinhardt do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[samuel-reinhardt]

@magento give me 2.3-develop instance

[magento-engcom-team]

Hi @samuel-reinhardt. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @samuel-reinhardt, here is your Magento instance.
Admin access: https://i-23638-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[m2-assistant]

Hi @engcom-Charlie. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[samuel-reinhardt]

This issue is not present on 2.2-develop or 2.3-develop. 2.2 and 2.3 releases do contain the issue however. It is due to this commit in which a salable check is added to the sample downloads logic.
9498c97#diff-3ce343f8897fe36416d4a848dab0a7da

[magento-engcom-team]

✅ Confirmed by @engcom-Charlie
Thank you for verifying the issue. Based on the provided information internal tickets MC-17998, MC-17999 were created

Issue Available: @engcom-Charlie, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.