Failure of "Send Order Email Copy" spams customers, every minute, forever.

[lingwooc]

Magento 2.2.5 resends emails to customers if the "Send Order Email Copy" feature fails. This is due to a naive check in Magento\Sales\Model\Order\Email\Sender.php . It was PR #14051 to fix #13769 that did it.

It doesn't discriminate between a failure in the email copy (probably to a company address) and an email to a customer. If the copy fails repeatedly (I've literally never had this feature work) then it will spam your customers once a minute for ever. This is super dumb.

This is the code:

        try {
            $sender->send();
            $sender->sendCopyTo();
        } catch (\Exception $e) {
            $this->logger->error($e->getMessage());

            return false;
        }

        return true;

It should probably be:

        try {
            $sender->send();
        } catch (\Exception $e) {
                $this->logger->error($e->getMessage());
            return false;
        }
        try {
            $sender->sendCopyTo();
        } catch (\Exception $e) {
            $this->logger->error($e->getMessage());
        }
        return true;

Although really its a great demonstration of why using a boolean to determine an error state isn't a great idea.

Preconditions

Magento 2.2.5
Broken "Send Order Email Copy"
Asyncronous email sending

Steps to reproduce

1. Set magento2 to send a separate email copy of an order
2. Turn on "Asyncronous email sending"
3. Make an order

Expected result

1. Set magento2 to send a separate email copy of an order
2. Turn on "Asyncronous email sending"
3. Make an order
   4 Don't spam customers

Actual result

1. Set magento2 to send a seperate email copy of an order
2. Turn on "Asyncronous email sending"
3. Make an order
4. Spam your customers

[magento-engcom-team]

Hi @lingwooc. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +).
For more details, please, review the Magento Contributor Assistant documentation.

@lingwooc do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[engcom-backlog-nickolas]

Hello @lingwooc, thank you for your report.
We've acknowledged the issue and added to our backlog.

[sambolek]

#mm18hr